From: "Bruno Prémont" <bonbons@linux-vserver.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: linux-kernel@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH 7/9] drivers/hid/hid-picolcd_fb: avoid world-writable sysfs files.
Date: Fri, 2 May 2014 21:43:54 +0200 [thread overview]
Message-ID: <20140502214354.67061986@neptune.home> (raw)
In-Reply-To: <1398137612-9714-8-git-send-email-rusty@rustcorp.com.au>
On Tue, 22 April 2014 Rusty Russell <rusty@rustcorp.com.au> wrote:
> In line with practice for module parameters, we're adding a build-time
> check that sysfs files aren't world-writable.
>
> Cc: Bruno Prémont <bonbons@linux-vserver.org>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Fine with me,
Acked-by: Bruno Prémont <bonbons@linux-vserver.org>
Not sure which tree you plan to push this through, CCing Jiri
as all picoLCD driver went in via HID tree.
> ---
> drivers/hid/hid-picolcd_fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c
> index c930ab8554ea..7f965e231433 100644
> --- a/drivers/hid/hid-picolcd_fb.c
> +++ b/drivers/hid/hid-picolcd_fb.c
> @@ -501,7 +501,7 @@ static ssize_t picolcd_fb_update_rate_store(struct device *dev,
> return count;
> }
>
> -static DEVICE_ATTR(fb_update_rate, 0666, picolcd_fb_update_rate_show,
> +static DEVICE_ATTR(fb_update_rate, 0664, picolcd_fb_update_rate_show,
> picolcd_fb_update_rate_store);
>
> /* initialize Framebuffer device */
next prev parent reply other threads:[~2014-05-02 19:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 3:33 [PATCH 0/9] Avoid " Rusty Russell
2014-04-22 3:33 ` [PATCH 1/9] drivers/mtd/devices/docg3.c: avoid " Rusty Russell
2014-04-22 3:33 ` [PATCH 2/9] drivers/video/fbdev/sm501fb.c: " Rusty Russell
2014-04-22 3:33 ` [PATCH 3/9] drivers/hid/hid-lg4ff.c: " Rusty Russell
2014-04-22 16:30 ` simon
2014-04-23 5:34 ` Rusty Russell
2014-04-23 15:06 ` simon
2014-04-24 3:25 ` Rusty Russell
[not found] ` <gz6xrj.n4iwpm.2st9zt-qmf@smtp.devoid-pointer.net>
2014-04-24 7:14 ` Rusty Russell
2014-04-22 3:33 ` [PATCH 4/9] drivers/scsi/pm8001/pm8001_ctl.c: " Rusty Russell
2014-04-22 3:33 ` [PATCH 5/9] drivers/regulator/virtual: " Rusty Russell
2014-04-22 3:33 ` [PATCH 6/9] drivers/staging/speakup/: " Rusty Russell
2014-04-22 16:37 ` Greg Kroah-Hartman
2014-04-24 4:27 ` Rusty Russell
2014-04-24 19:29 ` Greg Kroah-Hartman
2014-04-22 3:33 ` [PATCH 7/9] drivers/hid/hid-picolcd_fb: " Rusty Russell
2014-05-02 19:43 ` Bruno Prémont [this message]
2014-05-05 1:57 ` Rusty Russell
2014-05-05 9:02 ` Jiri Kosina
2014-04-22 3:33 ` [PATCH 8/9] samples/kobject/: " Rusty Russell
2014-04-22 16:38 ` Greg Kroah-Hartman
2014-04-22 3:33 ` [PATCH 9/9] sysfs: disallow world-writable files Rusty Russell
2015-04-29 12:24 ` Gobinda Charan Maji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502214354.67061986@neptune.home \
--to=bonbons@linux-vserver.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®