From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jiang Liu <jiang.liu@linux.intel.com>,
Ingo Molnar <mingo@kernel.org>, Ingo Molnar <mingo@redhat.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Bugfix] sched: fix possible invalid memory access caused by CPU hot-addition
Date: Wed, 23 Apr 2014 04:05:24 +0200 [thread overview]
Message-ID: <1398218724.5339.16.camel@marge.simpson.net> (raw)
In-Reply-To: <20140422200449.GF11096@twins.programming.kicks-ass.net>
On Tue, 2014-04-22 at 22:04 +0200, Peter Zijlstra wrote:
> On Tue, Apr 22, 2014 at 01:01:51PM -0700, Andrew Morton wrote:
> > On Tue, 22 Apr 2014 10:15:15 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > > On Tue, Apr 22, 2014 at 01:27:15PM +0800, Jiang Liu wrote:
> > > > When calling kzalloc_node(size, flags, node), we should first check
> > > > whether node is onlined, otherwise it may cause invalid memory access
> > > > as below.
> > >
> > > But this is only for memory less node crap, right?
> >
> > um, why are memoryless nodes crap?
>
> Why wouldn't they be? Having CPUs with no local memory seems decidedly
> suboptimal.
This ain't exactly wonderful either, makes CPU domains to crawl over.
node 0 cpus: 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179
node 0 size: 31723 MB
node 0 free: 27949 MB
node 1 cpus: 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149
node 1 size: 32308 MB
node 1 free: 31033 MB
node 2 cpus:
node 2 size: 32768 MB
node 2 free: 16631 MB
node 3 cpus:
node 3 size: 32768 MB
node 3 free: 32640 MB
node 4 cpus:
node 4 size: 32768 MB
node 4 free: 32640 MB
node 5 cpus:
node 5 size: 32768 MB
node 5 free: 32638 MB
node distances:
node 0 1 2 3 4 5
0: 10 12 12 15 12 15
1: 12 10 15 12 15 15
2: 12 15 10 12 15 15
3: 15 12 12 10 15 12
4: 12 15 15 15 10 12
5: 15 15 15 12 12 10
next prev parent reply other threads:[~2014-04-23 2:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 5:27 Jiang Liu
2014-04-22 8:15 ` Peter Zijlstra
2014-04-22 20:01 ` Andrew Morton
2014-04-22 20:04 ` Peter Zijlstra
2014-04-23 1:59 ` David Rientjes
2014-04-23 4:53 ` Jiang Liu
2014-04-23 2:05 ` Mike Galbraith [this message]
2014-04-23 2:45 ` Jiang Liu
2014-04-23 5:32 ` Peter Zijlstra
2014-04-23 5:45 ` Jiang Liu
2014-04-23 5:51 ` Peter Zijlstra
2014-04-23 17:46 ` Luck, Tony
2014-04-24 2:59 ` Jiang Liu
2014-04-24 7:47 ` Peter Zijlstra
2014-04-24 17:41 ` Luck, Tony
2014-04-24 19:09 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398218724.5339.16.camel@marge.simpson.net \
--to=umgwanakikbuti@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome