From: Peter Zijlstra <peterz@infradead.org>
To: Jiang Liu <jiang.liu@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>, Ingo Molnar <mingo@redhat.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Bugfix] sched: fix possible invalid memory access caused by CPU hot-addition
Date: Wed, 23 Apr 2014 07:32:13 +0200 [thread overview]
Message-ID: <20140423053213.GV26782@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <53572939.7020509@linux.intel.com>
On Wed, Apr 23, 2014 at 10:45:13AM +0800, Jiang Liu wrote:
> Hi Peter,
> It's not for memoryless node, but to solve a race window
> in CPU hot-addition. The related CPU hot-addition flow is:
> 1) Handle CPU hot-addition event
> 1.a) gather platform specific information
> 1.b) associate hot-added CPU with a node
> 1.c) create CPU device
> 2) User online hot-added CPUs through sysfs:
> 2.a) cpu_up()
> 2.b) ->try_online_node()
> 2.c) ->hotadd_new_pgdat()
> 2.d) ->node_set_online()
>
> So between 1.b and 2.c, kmalloc_node(nid) may cause invalid
> memory access without the node_online(nid) check.
Any why was all this not in the Changelog?
next prev parent reply other threads:[~2014-04-23 5:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 5:27 Jiang Liu
2014-04-22 8:15 ` Peter Zijlstra
2014-04-22 20:01 ` Andrew Morton
2014-04-22 20:04 ` Peter Zijlstra
2014-04-23 1:59 ` David Rientjes
2014-04-23 4:53 ` Jiang Liu
2014-04-23 2:05 ` Mike Galbraith
2014-04-23 2:45 ` Jiang Liu
2014-04-23 5:32 ` Peter Zijlstra [this message]
2014-04-23 5:45 ` Jiang Liu
2014-04-23 5:51 ` Peter Zijlstra
2014-04-23 17:46 ` Luck, Tony
2014-04-24 2:59 ` Jiang Liu
2014-04-24 7:47 ` Peter Zijlstra
2014-04-24 17:41 ` Luck, Tony
2014-04-24 19:09 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423053213.GV26782@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome