* [PATCH] misc: genwqe: Fix format string mismatch in card_debugfs.c
@ 2014-04-24 3:25 Masanari Iida
2014-05-05 14:21 ` Frank Haverkamp
0 siblings, 1 reply; 2+ messages in thread
From: Masanari Iida @ 2014-04-24 3:25 UTC (permalink / raw)
To: arnd, gregkh, linux-kernel; +Cc: haver, Masanari Iida
Fix two format string mismatch in genwqe_init_debugfs()
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
drivers/misc/genwqe/card_debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/genwqe/card_debugfs.c b/drivers/misc/genwqe/card_debugfs.c
index 50d2096..0a33ade 100644
--- a/drivers/misc/genwqe/card_debugfs.c
+++ b/drivers/misc/genwqe/card_debugfs.c
@@ -348,7 +348,7 @@ int genwqe_init_debugfs(struct genwqe_dev *cd)
char name[64];
unsigned int i;
- sprintf(card_name, "%s%u_card", GENWQE_DEVNAME, cd->card_idx);
+ sprintf(card_name, "%s%d_card", GENWQE_DEVNAME, cd->card_idx);
root = debugfs_create_dir(card_name, cd->debugfs_genwqe);
if (!root) {
@@ -454,7 +454,7 @@ int genwqe_init_debugfs(struct genwqe_dev *cd)
}
for (i = 0; i < GENWQE_MAX_VFS; i++) {
- sprintf(name, "vf%d_jobtimeout_msec", i);
+ sprintf(name, "vf%u_jobtimeout_msec", i);
file = debugfs_create_u32(name, 0666, root,
&cd->vf_jobtimeout_msec[i]);
--
2.0.0.rc0.26.g779792a
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] misc: genwqe: Fix format string mismatch in card_debugfs.c
2014-04-24 3:25 [PATCH] misc: genwqe: Fix format string mismatch in card_debugfs.c Masanari Iida
@ 2014-05-05 14:21 ` Frank Haverkamp
0 siblings, 0 replies; 2+ messages in thread
From: Frank Haverkamp @ 2014-05-05 14:21 UTC (permalink / raw)
To: Masanari Iida; +Cc: arnd, gregkh, linux-kernel
Am Donnerstag, den 24.04.2014, 12:25 +0900 schrieb Masanari Iida:
> Fix two format string mismatch in genwqe_init_debugfs()
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> ---
> drivers/misc/genwqe/card_debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/genwqe/card_debugfs.c b/drivers/misc/genwqe/card_debugfs.c
> index 50d2096..0a33ade 100644
> --- a/drivers/misc/genwqe/card_debugfs.c
> +++ b/drivers/misc/genwqe/card_debugfs.c
> @@ -348,7 +348,7 @@ int genwqe_init_debugfs(struct genwqe_dev *cd)
> char name[64];
> unsigned int i;
>
> - sprintf(card_name, "%s%u_card", GENWQE_DEVNAME, cd->card_idx);
> + sprintf(card_name, "%s%d_card", GENWQE_DEVNAME, cd->card_idx);
>
> root = debugfs_create_dir(card_name, cd->debugfs_genwqe);
> if (!root) {
> @@ -454,7 +454,7 @@ int genwqe_init_debugfs(struct genwqe_dev *cd)
> }
>
> for (i = 0; i < GENWQE_MAX_VFS; i++) {
> - sprintf(name, "vf%d_jobtimeout_msec", i);
> + sprintf(name, "vf%u_jobtimeout_msec", i);
>
> file = debugfs_create_u32(name, 0666, root,
> &cd->vf_jobtimeout_msec[i]);
Thanks for contributing the fix for our driver. I do not see that this
would ever be able to cause a problem. Or do I oversee something?
Regardless of that it appears to looks nicer.
Acked-by: Frank Haverkamp <haver@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-05 14:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-24 3:25 [PATCH] misc: genwqe: Fix format string mismatch in card_debugfs.c Masanari Iida
2014-05-05 14:21 ` Frank Haverkamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®