[PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

[PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

[Arnd Bergmann]

We specifically build the kernel with -Werror=date-time to detect
such macros, which gives us this error:

gs_fpgaboot/gs_fpgaboot.c:376:44: error: macro "__TIMESTAMP__" might prevent reproducible builds [-Werror=date-time]
  pr_info("built at %s UTC\n", __TIMESTAMP__);

The obvious fix is to remove the printk output line.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
index 89bc84d..7506900 100644
--- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
+++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
@@ -373,7 +373,6 @@ static int __init gs_fpgaboot_init(void)
 	r = -1;
 
 	pr_info("FPGA DOWNLOAD --->\n");
-	pr_info("built at %s UTC\n", __TIMESTAMP__);
 
 	pr_info("FPGA image file name: %s\n", file);
 

RE: [PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

[Insop Song]

________________________________________
From: Arnd Bergmann <arnd@arndb.de>
Sent: Tuesday, March 25, 2014 8:48 AM
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org; Insop Song
Subject: [PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

We specifically build the kernel with -Werror=date-time to detect
such macros, which gives us this error:

gs_fpgaboot/gs_fpgaboot.c:376:44: error: macro "__TIMESTAMP__" might prevent reproducible builds [-Werror=date-time]
  pr_info("built at %s UTC\n", __TIMESTAMP__);

The obvious fix is to remove the printk output line.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Insop Song <insop.song@gainspeed.com>

diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
index 89bc84d..7506900 100644
--- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
+++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
@@ -373,7 +373,6 @@ static int __init gs_fpgaboot_init(void)
        r = -1;

        pr_info("FPGA DOWNLOAD --->\n");
-       pr_info("built at %s UTC\n", __TIMESTAMP__);

        pr_info("FPGA image file name: %s\n", file);

Re: [PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

[Geert Uytterhoeven]

On Tue, Mar 25, 2014 at 4:48 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> We specifically build the kernel with -Werror=date-time to detect
> such macros, which gives us this error:
>
> gs_fpgaboot/gs_fpgaboot.c:376:44: error: macro "__TIMESTAMP__" might prevent reproducible builds [-Werror=date-time]
>   pr_info("built at %s UTC\n", __TIMESTAMP__);

Worse, gcc 4.1.2 doesn't seem to understand __TIMESTAMP__:

drivers/staging/gs_fpgaboot/gs_fpgaboot.c: In function ‘gs_fpgaboot_init’:
drivers/staging/gs_fpgaboot/gs_fpgaboot.c:376: error: ‘__TIMESTAMP__’
undeclared (first use in this function)
drivers/staging/gs_fpgaboot/gs_fpgaboot.c:376: error: (Each undeclared
identifier is reported only once
drivers/staging/gs_fpgaboot/gs_fpgaboot.c:376: error: for each
function it appears in.)

> The obvious fix is to remove the printk output line.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

> diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
> index 89bc84d..7506900 100644
> --- a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
> +++ b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
> @@ -373,7 +373,6 @@ static int __init gs_fpgaboot_init(void)
>         r = -1;
>
>         pr_info("FPGA DOWNLOAD --->\n");
> -       pr_info("built at %s UTC\n", __TIMESTAMP__);
>
>         pr_info("FPGA image file name: %s\n", file);
>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH] staging: gs_fpgaboot: remove __TIMESTAMP__ macro

[Insop Song]

Remove warning

Insop Song (1):
  Remove warning printk

 drivers/staging/gs_fpgaboot/gs_fpgaboot.c |    1 -
 1 file changed, 1 deletion(-)

-- 
1.7.9.5