From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Amit Singh <quic_amitsi@quicinc.com>,
andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_riteshk@quicinc.com,
quic_rajeevny@quicinc.com, quic_vproddut@quicinc.com
Subject: Re: [PATCH] arm64: dts: qcom: qcs6490-rb3gen2: Use 'edp_hot' function for hpd gpio
Date: Fri, 31 Oct 2025 10:07:56 +0100 [thread overview]
Message-ID: <1398b513-0948-4775-a71d-dd06ee2296f9@oss.qualcomm.com> (raw)
In-Reply-To: <20251031085739.440153-1-quic_amitsi@quicinc.com>
On 10/31/25 9:57 AM, Amit Singh wrote:
> Currently, hpd gpio is configured as a general-purpose gpio, which does
> not support interrupt generation. This change removes the generic
> hpd-gpios property and assigns the edp_hot function to the pin,
> enabling proper irq support.
>
> Fixes: 756efb7cb7293 ("arm64: dts: qcom: qcs6490-rb3gen2: Add DP output")
> Signed-off-by: Amit Singh <quic_amitsi@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> index c146161e4bb4..caa0b6784df3 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> @@ -49,8 +49,6 @@ dp-connector {
> label = "DP";
> type = "mini";
>
> - hpd-gpios = <&tlmm 60 GPIO_ACTIVE_HIGH>;
I think this change will take away DRM_BRIDGE_OP_DETECT which is very
much desired to have.. (via display_connector_probe())
Konrad
> -
> port {
> dp_connector_in: endpoint {
> remote-endpoint = <&mdss_edp_out>;
> @@ -1420,7 +1418,6 @@ &wifi {
> /* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */
>
> &edp_hot_plug_det {
> - function = "gpio";
> bias-disable;
> };
>
next prev parent reply other threads:[~2025-10-31 9:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 8:57 Amit Singh
2025-10-31 9:07 ` Konrad Dybcio [this message]
2025-11-06 8:23 ` Amit Singh
2025-11-06 10:24 ` Konrad Dybcio
2025-11-01 9:18 ` Dmitry Baryshkov
2025-11-06 8:29 ` Amit Singh
2025-11-01 18:59 ` Bjorn Andersson
2025-11-06 9:31 ` Amit Singh
2025-11-11 15:14 ` Dmitry Baryshkov
2025-11-11 16:47 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398b513-0948-4775-a71d-dd06ee2296f9@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_amitsi@quicinc.com \
--cc=quic_rajeevny@quicinc.com \
--cc=quic_riteshk@quicinc.com \
--cc=quic_vproddut@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®