Re: [PATCH] arm64: dts: qcom: qcs6490-rb3gen2: Use 'edp_hot' function for hpd gpio

[Amit Singh <quic_amitsi@quicinc.com>]

On 10/31/2025 2:37 PM, Konrad Dybcio wrote:
> On 10/31/25 9:57 AM, Amit Singh wrote:
>> Currently, hpd gpio is configured as a general-purpose gpio, which does
>> not support interrupt generation. This change removes the generic
>> hpd-gpios property and assigns the edp_hot function to the pin,
>> enabling proper irq support.
>>
>> Fixes: 756efb7cb7293 ("arm64: dts: qcom: qcs6490-rb3gen2: Add DP output")
>> Signed-off-by: Amit Singh <quic_amitsi@quicinc.com>
>> ---
>>  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> index c146161e4bb4..caa0b6784df3 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> @@ -49,8 +49,6 @@ dp-connector {
>>  		label = "DP";
>>  		type = "mini";
>>  
>> -		hpd-gpios = <&tlmm 60 GPIO_ACTIVE_HIGH>;
> 
> I think this change will take away DRM_BRIDGE_OP_DETECT which is very
> much desired to have.. (via display_connector_probe())
> 
> Konrad

Yes, this change will indeed remove DRM_BRIDGE_OP_DETECT.
We'll be relying on the internal HPD line (edp_hot) that's directly connected to the DP controller instead.

Do you foresee any specific issues with this approach?

> 
>> -
>>  		port {
>>  			dp_connector_in: endpoint {
>>  				remote-endpoint = <&mdss_edp_out>;
>> @@ -1420,7 +1418,6 @@ &wifi {
>>  /* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */
>>  
>>  &edp_hot_plug_det {
>> -	function = "gpio";
>>  	bias-disable;
>>  };
>>