From: Joe Perches <joe@perches.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, sarah.a.sharp@linux.intel.com,
Dan Williams <dan.j.williams@intel.com>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH 03/10] usb: catch attempts to submit urbs with a vmalloc'd transfer buffer
Date: Thu, 08 May 2014 09:47:34 -0700 [thread overview]
Message-ID: <1399567654.7543.9.camel@joe-AO725> (raw)
In-Reply-To: <1399566363-25837-4-git-send-email-mathias.nyman@linux.intel.com>
On Thu, 2014-05-08 at 19:25 +0300, Mathias Nyman wrote:
> Save someone else the debug cycles of figuring out why a driver's
> transfer request is failing or causing undefined system behavior.
> Buffers submitted for dma must come from GFP allocated / DMA-able
> memory.
>
> Return -EAGAIN matching the return value for dma_mapping_error() cases.
[]
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
[]
> @@ -1502,6 +1502,9 @@ int usb_hcd_map_urb_for_dma(struct usb_hcd *hcd, struct urb *urb,
> ret = -EAGAIN;
> else
> urb->transfer_flags |= URB_DMA_MAP_PAGE;
> + } else if (is_vmalloc_addr(urb->transfer_buffer)) {
> + WARN_ONCE(1, "transfer buffer not dma capable\n");
> + ret = -EAGAIN;
> } else {
> urb->transfer_dma = dma_map_single(
> hcd->self.controller,
Perhaps this could be #ifdef'd here or moved to and
tested in dma_map_single/dma_map_single_attr instead.
next prev parent reply other threads:[~2014-05-08 16:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 16:25 [PATCH 00/10] xhci: features for usb-next Mathias Nyman
2014-05-08 16:25 ` [PATCH 01/10] xhci: fix wrong port number reported when setting USB2.0 hardware LPM Mathias Nyman
2014-05-08 16:25 ` [PATCH 02/10] xhci: 'noxhci_port_switch' kernel parameter Mathias Nyman
2014-05-20 1:01 ` Greg KH
2014-05-20 9:47 ` Mathias Nyman
2014-05-20 9:51 ` Takashi Iwai
2014-05-20 18:25 ` Dan Williams
2014-05-20 19:04 ` Takashi Iwai
2014-05-20 20:34 ` Greg KH
2014-05-20 22:40 ` Dan Williams
2014-05-21 0:27 ` Greg KH
2014-05-21 6:21 ` Dan Williams
2014-05-21 6:31 ` Greg KH
2014-05-21 17:29 ` Dan Williams
2014-05-21 17:52 ` Alan Stern
2014-05-21 21:59 ` Greg KH
2014-05-24 6:39 ` Holger Hans Peter Freyther
2014-05-24 14:13 ` Dan Williams
2014-07-11 10:08 ` Holger Hans Peter Freyther
2014-05-08 16:25 ` [PATCH 03/10] usb: catch attempts to submit urbs with a vmalloc'd transfer buffer Mathias Nyman
2014-05-08 16:21 ` Dan Williams
2014-05-12 15:01 ` Mathias Nyman
2014-05-20 0:58 ` Greg KH
2014-05-08 16:22 ` David Laight
2014-05-08 16:32 ` Dan Williams
2014-05-08 16:47 ` Joe Perches [this message]
2014-05-08 17:05 ` Dan Williams
2014-05-08 16:25 ` [PATCH 04/10] usb: xhci: Use IS_ENABLED() macro Mathias Nyman
2014-05-08 16:25 ` [PATCH 05/10] xhci: Use pci_enable_msix_exact() instead of pci_enable_msix() Mathias Nyman
2014-05-08 16:25 ` [PATCH 06/10] xhci: Report max device limit when Enable Slot command fails Mathias Nyman
2014-05-08 16:26 ` [PATCH 07/10] xhci: Use command structures when queuing commands on the command ring Mathias Nyman
2014-06-05 22:16 ` Dan Williams
2014-06-06 8:14 ` Mathias Nyman
2014-05-08 16:26 ` [PATCH 08/10] xhci: Add a global command queue Mathias Nyman
2014-05-08 16:26 ` [PATCH 09/10] xhci: Use completion and status in " Mathias Nyman
2014-05-08 16:26 ` [PATCH 10/10] xhci: rework command timeout and cancellation, Mathias Nyman
2014-05-15 15:44 ` [PATCH 00/10] xhci: features for usb-next Mathias Nyman
2014-05-20 1:04 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399567654.7543.9.camel@joe-AO725 \
--to=joe@perches.com \
--cc=dan.j.williams@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®