[PATCH 1/1] fs/cifs/netmisc.c: convert printk to pr_foo()

[PATCH 1/1] fs/cifs/netmisc.c: convert printk to pr_foo()

[Fabian Frederick]

Also fixes array checkpatch warning.

Cc: Steve French <sfrench@samba.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 fs/cifs/netmisc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
index 0498845..4def0ae 100644
--- a/fs/cifs/netmisc.c
+++ b/fs/cifs/netmisc.c
@@ -795,8 +795,8 @@ cifs_print_status(__u32 status_code)
 	while (nt_errs[idx].nt_errstr != NULL) {
 		if (((nt_errs[idx].nt_errcode) & 0xFFFFFF) ==
 		    (status_code & 0xFFFFFF)) {
-			printk(KERN_NOTICE "Status code returned 0x%08x %s\n",
-				   status_code, nt_errs[idx].nt_errstr);
+			pr_notice("Status code returned 0x%08x %s\n",
+				  status_code, nt_errs[idx].nt_errstr);
 		}
 		idx++;
 	}
@@ -941,8 +941,8 @@ cifs_UnixTimeToNT(struct timespec t)
 	return (u64) t.tv_sec * 10000000 + t.tv_nsec/100 + NTFS_TIME_OFFSET;
 }
 
-static int total_days_of_prev_months[] =
-{0, 31, 59, 90, 120, 151, 181, 212, 243, 273, 304, 334};
+static int total_days_of_prev_months[] = {
+	0, 31, 59, 90, 120, 151, 181, 212, 243, 273, 304, 334};
 
 struct timespec cnvrtDosUnixTm(__le16 le_date, __le16 le_time, int offset)
 {
-- 
1.8.4.5

Re: [PATCH 1/1] fs/cifs/netmisc.c: convert printk to pr_foo()

[Joe Perches]

On Tue, 2014-05-13 at 18:10 +0200, Fabian Frederick wrote:
> Also fixes array checkpatch warning.
[]
> diff --git a/fs/cifs/netmisc.c b/fs/cifs/netmisc.c
[]
> @@ -941,8 +941,8 @@ cifs_UnixTimeToNT(struct timespec t)
>  	return (u64) t.tv_sec * 10000000 + t.tv_nsec/100 + NTFS_TIME_OFFSET;
>  }
>  
> -static int total_days_of_prev_months[] =
> -{0, 31, 59, 90, 120, 151, 181, 212, 243, 273, 304, 334};
> +static int total_days_of_prev_months[] = {
> +	0, 31, 59, 90, 120, 151, 181, 212, 243, 273, 304, 334};

Hi Fabian.

A preferred form for initialized array declarations is

type array[] = {
	val1, val2, ..., valn
};

Also this instance should probably be static const.