mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Thumshirn <morbidrsa@gmail.com>
To: Filip Jensen <dev-Felipe.Jensen@duagon.com>
Cc: linux-kernel@vger.kernel.org,
	Jose Javier Rodriguez Barbarin
	<dev-josejavier.rodriguez@duagon.com>
Subject: Re: [PATCH 2/3] mcb: Fix detection of iomapped pci devices
Date: Fri, 27 Feb 2026 14:57:48 +0100	[thread overview]
Message-ID: <13bc7f93-6aef-4f63-a0a8-d5eec4dc8062@gmail.com> (raw)
In-Reply-To: <20260226151339.48800-3-dev-Felipe.Jensen@duagon.com>

On 2/26/26 4:13 PM, Filip Jensen wrote:
> The mcb driver in a PCI bus is not detecting if an attached device has
> an iomapped or a memory mapped BAR, as all the addresses returned by
> pci_resource_start end in 0.
>
> Instead of the low level approach, which is still valid for lpc buses,
> here it will be used the standard PCI helper pci_resource_flags for
> checking if the PCI BAR is IO mapped (as it is done in mcb_pci_probe)

Hi Filip,

I think this patch is not needed, because in patch 3/3 you change all of 
it again to use the 'chameleon_parse_ops' you introduced. Which IMHO is 
the cleaner approach anyways.

Thanks,

Johannes


  reply	other threads:[~2026-02-27 13:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 15:13 [PATCH 0/3] mcb: enable register PCI devices using any BAR Filip Jensen
2026-02-26 15:13 ` [PATCH 1/3] mcb: Use more than the first bar in pci devices Filip Jensen
2026-02-26 15:13 ` [PATCH 2/3] mcb: Fix detection of iomapped " Filip Jensen
2026-02-27 13:57   ` Johannes Thumshirn [this message]
2026-02-26 15:13 ` [PATCH 3/3] mcb: refactor the bus operations out of the common code Filip Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13bc7f93-6aef-4f63-a0a8-d5eec4dc8062@gmail.com \
    --to=morbidrsa@gmail.com \
    --cc=dev-Felipe.Jensen@duagon.com \
    --cc=dev-josejavier.rodriguez@duagon.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®