From: Joe Perches <joe@perches.com>
To: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: Marek Belisko <marek.belisko@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH 04/19] staging: ft1000: Remove unnecessary externs
Date: Mon, 10 Aug 2015 14:51:19 -0700 [thread overview]
Message-ID: <13f0effe886f40ca747e0dfe7383e5c4871ebe4e.1439241825.git.joe@perches.com> (raw)
In-Reply-To: <cover.1439241825.git.joe@perches.com>
Using 'extern' is not necessary for function prototypes.
Miscellanea:
o Reflow alignment
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000.h | 19 +++++++++----------
drivers/staging/ft1000/ft1000-usb/ft1000_usb.h | 4 ++--
2 files changed, 11 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h b/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h
index 5992670..e1861cf 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000.h
@@ -42,17 +42,16 @@ struct ft1000_pcmcia {
struct pcmcia_device;
struct net_device;
-extern struct net_device *init_ft1000_card(struct pcmcia_device *link,
- void *ft1000_reset);
-extern void stop_ft1000_card(struct net_device *dev);
-extern int card_download(struct net_device *dev, const u8 *pFileStart,
- size_t FileLength);
+struct net_device *init_ft1000_card(struct pcmcia_device *link,
+ void *ft1000_reset);
+void stop_ft1000_card(struct net_device *dev);
+int card_download(struct net_device *dev, const u8 *pFileStart,
+ size_t FileLength);
-extern u16 ft1000_read_dpram(struct net_device *dev, int offset);
-extern void card_bootload(struct net_device *dev);
-extern u16 ft1000_read_dpram_mag_16(struct net_device *dev, int offset,
- int Index);
-extern u32 ft1000_read_dpram_mag_32(struct net_device *dev, int offset);
+u16 ft1000_read_dpram(struct net_device *dev, int offset);
+void card_bootload(struct net_device *dev);
+u16 ft1000_read_dpram_mag_16(struct net_device *dev, int offset, int Index);
+u32 ft1000_read_dpram_mag_32(struct net_device *dev, int offset);
void ft1000_write_dpram_mag_32(struct net_device *dev, int offset, u32 value);
/* Read the value of a given ASIC register. */
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.h b/drivers/staging/ft1000/ft1000-usb/ft1000_usb.h
index fea60d5..9b5050f 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_usb.h
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_usb.h
@@ -134,8 +134,8 @@ extern spinlock_t free_buff_lock;
int ft1000_create_dev(struct ft1000_usb *dev);
void ft1000_destroy_dev(struct net_device *dev);
-extern int card_send_command(struct ft1000_usb *ft1000dev,
- void *ptempbuffer, int size);
+int card_send_command(struct ft1000_usb *ft1000dev,
+ void *ptempbuffer, int size);
struct dpram_blk *ft1000_get_buffer(struct list_head *bufflist);
void ft1000_free_buffer(struct dpram_blk *pdpram_blk, struct list_head *plist);
--
2.1.2
next prev parent reply other threads:[~2015-08-10 21:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 21:51 [PATCH 00/19] staging: " Joe Perches
2015-08-10 21:51 ` [PATCH 01/19] staging: android: " Joe Perches
2015-08-10 21:51 ` [PATCH 02/19] staging: dgnc: " Joe Perches
2015-08-10 21:51 ` [PATCH 03/19] staging: fbtft: " Joe Perches
2015-08-10 21:51 ` Joe Perches [this message]
2015-08-10 21:51 ` [PATCH 05/19] staging: iio: " Joe Perches
2015-08-11 18:43 ` Lars-Peter Clausen
2015-08-15 19:57 ` Jonathan Cameron
2015-08-15 20:05 ` Lars-Peter Clausen
2015-08-15 20:33 ` Jonathan Cameron
2015-08-10 21:51 ` [PATCH 06/19] staging: lustre: " Joe Perches
2015-08-10 21:51 ` [PATCH 07/19] staging: most: " Joe Perches
2015-08-14 8:36 ` Andrey Shvetsov
2015-08-14 10:50 ` Dan Carpenter
2015-08-10 21:51 ` [PATCH 08/19] staging: mt29f_spinand: " Joe Perches
2015-08-10 21:51 ` [PATCH 09/19] staging: netlogic: " Joe Perches
2015-08-10 21:51 ` [PATCH 10/19] staging: nvec: " Joe Perches
2015-08-10 21:51 ` [PATCH 11/19] staging: octeon: " Joe Perches
2015-08-10 22:16 ` David Daney
2015-08-10 21:51 ` [PATCH 12/19] staging: olpc_dcon: " Joe Perches
2015-08-10 21:51 ` [PATCH 13/19] staging: rtl8188eu: " Joe Perches
2015-08-10 21:51 ` [PATCH 14/19] staging: rtl8192e: " Joe Perches
2015-08-10 21:51 ` [PATCH 15/19] staging: rtl8192u: " Joe Perches
2015-08-10 21:51 ` [PATCH 16/19] staging: rtl8712: " Joe Perches
2015-08-10 21:51 ` [PATCH 17/19] staging: speakup: " Joe Perches
2015-08-10 21:51 ` [PATCH 18/19] staging: wilc1000: " Joe Perches
2015-08-10 21:51 ` [PATCH 19/19] staging: xgifb: " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13f0effe886f40ca747e0dfe7383e5c4871ebe4e.1439241825.git.joe@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®