mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Ziegler <andreas.ziegler@fau.de>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regmap: make LZO cache optional
Date: Thu, 8 Jun 2017 16:28:25 +0200	[thread overview]
Message-ID: <13f337ad-83ba-5542-0d6f-61282d2afce2@fau.de> (raw)
In-Reply-To: 

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

Hi Jonas,

I noticed your patch 'regmap: make LZO cache optional' as it recently showed up
in linux-next. In your patch, you modify drivers/base/regmap/regcache.c by
adding an #if IS_ENABLED() statement.

However, this statement contains a spelling error, as it references
REGCHACHE_COMPRESSED instead of REGCACHE_COMPRESSED (note the extra H).

I noticed it by running the in-tree script at scripts/checkkconfigsymbols.py on
the commit, like so: './scripts/checkkconfigsymbols.py -c 34a730aa74c7'

As Greg suggested the whole code could be dropped, this might not be too
relevant, but I wanted to let you know in any case.

Best regards,

Andreas


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5450 bytes --]

             reply	other threads:[~2017-06-08 14:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-08 14:28 Andreas Ziegler [this message]
2017-06-11 10:26 ` Jonas Gorski
  -- strict thread matches above, loose matches on Subject: below --
2017-06-02 13:15 Jonas Gorski
2017-06-03  0:58 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13f337ad-83ba-5542-0d6f-61282d2afce2@fau.de \
    --to=andreas.ziegler@fau.de \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jonas.gorski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®