From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] regmap: make LZO cache optional
Date: Sat, 3 Jun 2017 09:58:45 +0900 [thread overview]
Message-ID: <20170603005845.GB24565@kroah.com> (raw)
In-Reply-To: <20170602131537.22180-1-jonas.gorski@gmail.com>
On Fri, Jun 02, 2017 at 03:15:37PM +0200, Jonas Gorski wrote:
> Commit 2cbbb579bcbe3 ("regmap: Add the LZO cache support") added support
> for LZO compression in regcache, but there were never any users added
> afterwards. Since LZO support itself has its own size, it currently is
> rather a deoptimization.
>
> So make it optional by introducing a symbol that can be selected by
> drivers wanting to make use of it.
>
> Saves e.g. ~46 kB on MIPS (size of LZO support + regcache LZO code).
>
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
> ---
> I tried using google to find any users (even out-of-tree ones), but at
> best I found a single driver submission that was switched to RBTREE in
> subsequent resubmissions (MFD_SMSC).
>
> One could maybe also just drop the code because of no users for 5 years,
> but that would be up to the maintainer(s) to decide.
Let's just drop it, if there are no users, it shouldn't be there at all.
thanks,
greg k-h
next prev parent reply other threads:[~2017-06-03 0:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 13:15 Jonas Gorski
2017-06-03 0:58 ` Greg Kroah-Hartman [this message]
2017-06-06 19:06 ` Applied "regmap: make LZO cache optional" to the regmap tree Mark Brown
2017-06-08 14:28 [PATCH] regmap: make LZO cache optional Andreas Ziegler
2017-06-11 10:26 ` Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170603005845.GB24565@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=jonas.gorski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®