From: Borislav Petkov <bp@alien8.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Borislav Petkov <bp@suse.de>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Ingo Molnar <mingo@kernel.org>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
"Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: [PATCH] intel_rapl: Correct hotplug correction
Date: Thu, 22 May 2014 11:23:44 +0200 [thread overview]
Message-ID: <1400750624-19238-1-git-send-email-bp@alien8.de> (raw)
From: Borislav Petkov <bp@suse.de>
So 009f225ef050 ("powercap, intel-rapl: Fix CPU hotplug callback
registration") says how get_/put_online_cpus() should be replaced with
this cpu_notifier_register_begin/_done().
But they're still there so what's up?
Let me do what was supposed to be done.
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
---
drivers/powercap/intel_rapl.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c
index d9a0770b6c73..9055f3df1f64 100644
--- a/drivers/powercap/intel_rapl.c
+++ b/drivers/powercap/intel_rapl.c
@@ -1377,8 +1377,6 @@ static int __init rapl_init(void)
cpu_notifier_register_begin();
- /* prevent CPU hotplug during detection */
- get_online_cpus();
ret = rapl_detect_topology();
if (ret)
goto done;
@@ -1390,7 +1388,6 @@ static int __init rapl_init(void)
}
__register_hotcpu_notifier(&rapl_cpu_notifier);
done:
- put_online_cpus();
cpu_notifier_register_done();
return ret;
--
1.9.0
next reply other threads:[~2014-05-22 9:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 9:23 Borislav Petkov [this message]
2014-05-22 9:43 ` Srivatsa S. Bhat
2014-05-22 10:08 ` Borislav Petkov
2014-05-22 11:54 ` Srivatsa S. Bhat
2014-05-22 12:13 ` Borislav Petkov
2014-05-22 12:32 ` Peter Zijlstra
2014-05-22 15:30 ` [PATCH] x86, MCE: Kill CPU_POST_DEAD Borislav Petkov
2014-05-22 15:50 ` Luck, Tony
2014-05-22 19:55 ` Borislav Petkov
2014-05-22 21:13 ` Srivatsa S. Bhat
2014-05-22 21:31 ` Borislav Petkov
2014-05-22 21:40 ` Srivatsa S. Bhat
2014-05-22 21:43 ` Srivatsa S. Bhat
2014-05-26 20:01 ` Borislav Petkov
2014-05-22 21:31 ` [PATCH] intel_rapl: Correct hotplug correction Srivatsa S. Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400750624-19238-1-git-send-email-bp@alien8.de \
--to=bp@alien8.de \
--cc=bp@suse.de \
--cc=jacob.jun.pan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®