[PATCH] drm/ttm: fix kerneldoc of ttm_bo_create

[PATCH] drm/ttm: fix kerneldoc of ttm_bo_create

[Alexandre Courbot]

The kerneldoc header of ttm_bo_create() was referring to another
(nonexisting) function and had a few obsolete or incorrect arguments.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
---
 include/drm/ttm/ttm_bo_api.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h
index ee127ec33c60..7526c5bf5610 100644
--- a/include/drm/ttm/ttm_bo_api.h
+++ b/include/drm/ttm/ttm_bo_api.h
@@ -485,13 +485,12 @@ extern int ttm_bo_init(struct ttm_bo_device *bdev,
 			void (*destroy) (struct ttm_buffer_object *));
 
 /**
- * ttm_bo_synccpu_object_init
+ * ttm_bo_create
  *
  * @bdev: Pointer to a ttm_bo_device struct.
- * @bo: Pointer to a ttm_buffer_object to be initialized.
  * @size: Requested size of buffer object.
  * @type: Requested type of buffer object.
- * @flags: Initial placement flags.
+ * @placement: Initial placement.
  * @page_alignment: Data alignment in pages.
  * @interruptible: If needing to sleep while waiting for GPU resources,
  * sleep interruptible.
-- 
1.9.2

[PATCH RESEND] drm/ttm: remove declaration of ttm_tt_cache_flush

[Alexandre Courbot]

ttm_tt_cache_flush's implementation was removed in 2009 by commit
c9c97b8c, but its declaration has been hiding in ttm_bo_driver.h since
then.

It has been surviving in the dark for too long now ; give it the mercy
blow.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
---
 include/drm/ttm/ttm_bo_driver.h | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
index a5183da3ef92..e3f8c99a8a9d 100644
--- a/include/drm/ttm/ttm_bo_driver.h
+++ b/include/drm/ttm/ttm_bo_driver.h
@@ -653,18 +653,6 @@ extern void ttm_tt_unbind(struct ttm_tt *ttm);
 extern int ttm_tt_swapin(struct ttm_tt *ttm);
 
 /**
- * ttm_tt_cache_flush:
- *
- * @pages: An array of pointers to struct page:s to flush.
- * @num_pages: Number of pages to flush.
- *
- * Flush the data of the indicated pages from the cpu caches.
- * This is used when changing caching attributes of the pages from
- * cache-coherent.
- */
-extern void ttm_tt_cache_flush(struct page *pages[], unsigned long num_pages);
-
-/**
  * ttm_tt_set_placement_caching:
  *
  * @ttm A struct ttm_tt the backing pages of which will change caching policy.
-- 
1.9.2

Re: [PATCH RESEND] drm/ttm: remove declaration of ttm_tt_cache_flush

[David Herrmann]

Hi

On Fri, May 23, 2014 at 5:58 AM, Alexandre Courbot <acourbot@nvidia.com> wrote:
> ttm_tt_cache_flush's implementation was removed in 2009 by commit
> c9c97b8c, but its declaration has been hiding in ttm_bo_driver.h since
> then.
>
> It has been surviving in the dark for too long now ; give it the mercy
> blow.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> Reviewed-by: Thierry Reding <treding@nvidia.com>

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

Thanks
David

> ---
>  include/drm/ttm/ttm_bo_driver.h | 12 ------------
>  1 file changed, 12 deletions(-)
>
> diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h
> index a5183da3ef92..e3f8c99a8a9d 100644
> --- a/include/drm/ttm/ttm_bo_driver.h
> +++ b/include/drm/ttm/ttm_bo_driver.h
> @@ -653,18 +653,6 @@ extern void ttm_tt_unbind(struct ttm_tt *ttm);
>  extern int ttm_tt_swapin(struct ttm_tt *ttm);
>
>  /**
> - * ttm_tt_cache_flush:
> - *
> - * @pages: An array of pointers to struct page:s to flush.
> - * @num_pages: Number of pages to flush.
> - *
> - * Flush the data of the indicated pages from the cpu caches.
> - * This is used when changing caching attributes of the pages from
> - * cache-coherent.
> - */
> -extern void ttm_tt_cache_flush(struct page *pages[], unsigned long num_pages);
> -
> -/**
>   * ttm_tt_set_placement_caching:
>   *
>   * @ttm A struct ttm_tt the backing pages of which will change caching policy.
> --
> 1.9.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/ttm: fix kerneldoc of ttm_bo_create

[David Herrmann]

Hi

On Fri, May 23, 2014 at 5:58 AM, Alexandre Courbot <acourbot@nvidia.com> wrote:
> The kerneldoc header of ttm_bo_create() was referring to another
> (nonexisting) function and had a few obsolete or incorrect arguments.
>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>

Reviewed-by: David Herrmann <dh.herrmann@gmail.com>

Thanks
David

> ---
>  include/drm/ttm/ttm_bo_api.h | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h
> index ee127ec33c60..7526c5bf5610 100644
> --- a/include/drm/ttm/ttm_bo_api.h
> +++ b/include/drm/ttm/ttm_bo_api.h
> @@ -485,13 +485,12 @@ extern int ttm_bo_init(struct ttm_bo_device *bdev,
>                         void (*destroy) (struct ttm_buffer_object *));
>
>  /**
> - * ttm_bo_synccpu_object_init
> + * ttm_bo_create
>   *
>   * @bdev: Pointer to a ttm_bo_device struct.
> - * @bo: Pointer to a ttm_buffer_object to be initialized.
>   * @size: Requested size of buffer object.
>   * @type: Requested type of buffer object.
> - * @flags: Initial placement flags.
> + * @placement: Initial placement.
>   * @page_alignment: Data alignment in pages.
>   * @interruptible: If needing to sleep while waiting for GPU resources,
>   * sleep interruptible.
> --
> 1.9.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel