* [PATCH 1/1] scripts/checkpatch.pl: device_initcall is not the only __initcall substitute
@ 2014-06-02 17:12 Fabian Frederick
2014-06-02 19:39 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-06-02 17:12 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, Andy Whitcroft, Joe Perches
This patch adds a link to init.h to find accurate initcall function
to replace obsolete __initcall
Cc: Andy Whitcroft <apw@canonical.com>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
scripts/checkpatch.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 34eb216..c981298 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4443,10 +4443,10 @@ sub process {
"$1 is obsolete, use k$3 instead\n" . $herecurr);
}
-# check for __initcall(), use device_initcall() explicitly please
+# check for __initcall(), use device_initcall() explicitly or more accurate function please
if ($line =~ /^.\s*__initcall\s*\(/) {
WARN("USE_DEVICE_INITCALL",
- "please use device_initcall() instead of __initcall()\n" . $herecurr);
+ "please use device_initcall() or more accurate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr);
}
# check for various ops structs, ensure they are const.
--
1.8.4.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] scripts/checkpatch.pl: device_initcall is not the only __initcall substitute
2014-06-02 17:12 [PATCH 1/1] scripts/checkpatch.pl: device_initcall is not the only __initcall substitute Fabian Frederick
@ 2014-06-02 19:39 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2014-06-02 19:39 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, Andy Whitcroft
On Mon, 2014-06-02 at 19:12 +0200, Fabian Frederick wrote:
> This patch adds a link to init.h to find accurate initcall function
> to replace obsolete __initcall
maybe s/accurate/appropriate/
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -4443,10 +4443,10 @@ sub process {
> "$1 is obsolete, use k$3 instead\n" . $herecurr);
> }
>
> -# check for __initcall(), use device_initcall() explicitly please
> +# check for __initcall(), use device_initcall() explicitly or more accurate function please
> if ($line =~ /^.\s*__initcall\s*\(/) {
> WARN("USE_DEVICE_INITCALL",
> - "please use device_initcall() instead of __initcall()\n" . $herecurr);
> + "please use device_initcall() or more accurate function instead of __initcall() (see include/linux/init.h)\n" . $herecurr);
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-02 19:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-02 17:12 [PATCH 1/1] scripts/checkpatch.pl: device_initcall is not the only __initcall substitute Fabian Frederick
2014-06-02 19:39 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®