From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Don@isotope.jf.intel.com, e1000-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Linux@isotope.jf.intel.com,
NICS <linux.nics@intel.com>,
Carolyn Wyborny <carolyn.wyborny@intel.com>,
netdev@vger.kernel.org
Subject: Re: [linux-nics] [PATCH] net: ethernet: intel: ixgbe: ixgbe_main.c: Cleaning up missing null-terminate after strncpy call
Date: Wed, 04 Jun 2014 16:45:17 -0700 [thread overview]
Message-ID: <1401925517.19767.175.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1401917380-2772-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
[-- Attachment #1: Type: text/plain, Size: 493 bytes --]
On Wed, 2014-06-04 at 23:29 +0200, Rickard Strandqvist wrote:
> Added a guaranteed null-terminate after call to strncpy.
>
> This was partly found using a static code analysis program called
> cppcheck.
>
> Signed-off-by: Rickard Strandqvist
> <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
NAK, I won't be picking this patch up based on Mark's and Joe's
feedback.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-06-04 23:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 21:29 Rickard Strandqvist
2014-06-04 21:55 ` Joe Perches
2014-06-04 22:14 ` [E1000-devel] " Rustad, Mark D
2014-06-04 23:45 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401925517.19767.175.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=Don@isotope.jf.intel.com \
--cc=Linux@isotope.jf.intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.nics@intel.com \
--cc=netdev@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®