From: "Rustad, Mark D" <mark.d.rustad@intel.com>
To: Joe Perches <joe@perches.com>
Cc: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
"e1000-devel@lists.sourceforge.net"
<e1000-devel@lists.sourceforge.net>,
"Allan, Bruce W" <bruce.w.allan@intel.com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>,
"Ronciak, John" <john.ronciak@intel.com>,
Netdev <netdev@vger.kernel.org>,
Linux NICS <Linux-nics@isotope.jf.intel.com>
Subject: Re: [E1000-devel] [PATCH] net: ethernet: intel: ixgbe: ixgbe_main.c: Cleaning up missing null-terminate after strncpy call
Date: Wed, 4 Jun 2014 22:14:05 +0000 [thread overview]
Message-ID: <21D85D78-EB7B-4C74-861B-43D7EDE350F7@intel.com> (raw)
In-Reply-To: <1401918909.26329.5.camel@joe-AO725>
On Jun 4, 2014, at 2:55 PM, Joe Perches <joe@perches.com> wrote:
> On Wed, 2014-06-04 at 23:29 +0200, Rickard Strandqvist wrote:
>> Added a guaranteed null-terminate after call to strncpy.
>
> Perhaps all of these should be strlcpy
The code that is there seems fine. The length of the array exceeds the length of the literal, and the strncpy ensures that the entire buffer is initialized so no information can possibly leak from the kernel.
I think this is fine as it is without any patch.
--
Mark Rustad, Networking Division, Intel Corporation
next prev parent reply other threads:[~2014-06-04 22:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 21:29 Rickard Strandqvist
2014-06-04 21:55 ` Joe Perches
2014-06-04 22:14 ` Rustad, Mark D [this message]
2014-06-04 23:45 ` [linux-nics] " Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21D85D78-EB7B-4C74-861B-43D7EDE350F7@intel.com \
--to=mark.d.rustad@intel.com \
--cc=Linux-nics@isotope.jf.intel.com \
--cc=bruce.w.allan@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jesse.brandeburg@intel.com \
--cc=joe@perches.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®