From: Michal Nazarewicz <mina86@mina86.com>
To: Felipe Balbi <balbi@ti.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Opasiak <k.opasiak@samsung.com>,
stable@vger.kernel.org, Michal Nazarewicz <mina86@mina86.com>
Subject: [PATCHv4 2/6] tools: ffs-test: fix header values endianess
Date: Fri, 13 Jun 2014 15:38:05 +0200 [thread overview]
Message-ID: <1402666689-4971-3-git-send-email-mina86@mina86.com> (raw)
In-Reply-To: <1402666689-4971-1-git-send-email-mina86@mina86.com>
It appears that no one ever run ffs-test on a big-endian machine,
since it used cpu-endianess for fs_count and hs_count fields which
should be in little-endian format. Fix by wrapping the numbers in
cpu_to_le32.
Cc: stable@vger.kernel.org
Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
---
tools/usb/ffs-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/usb/ffs-test.c b/tools/usb/ffs-test.c
index fe1e66b..a87e99f 100644
--- a/tools/usb/ffs-test.c
+++ b/tools/usb/ffs-test.c
@@ -116,8 +116,8 @@ static const struct {
.header = {
.magic = cpu_to_le32(FUNCTIONFS_DESCRIPTORS_MAGIC),
.length = cpu_to_le32(sizeof descriptors),
- .fs_count = 3,
- .hs_count = 3,
+ .fs_count = cpu_to_le32(3),
+ .hs_count = cpu_to_le32(3),
},
.fs_descs = {
.intf = {
--
2.0.0.526.g5318336
next prev parent reply other threads:[~2014-06-13 13:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 13:38 [PATCHv4 0/6] Various small USB fixes Michal Nazarewicz
2014-06-13 13:38 ` [PATCHv4 1/6] usb: gadget: f_fs: resurect usb_functionfs_descs_head structure Michal Nazarewicz
2014-06-13 13:38 ` Michal Nazarewicz [this message]
2014-06-13 13:38 ` [PATCHv4 3/6] usb: gadget: f_fs: add usb_functionfs_descs_head_v2 structure Michal Nazarewicz
2014-06-13 13:38 ` [PATCHv4 4/6] tools: ffs-test: convert to new descriptor format Michal Nazarewicz
2014-06-13 13:38 ` [PATCHv4 5/6] tools: ffs-test: add compatibility code for old kernels Michal Nazarewicz
2014-06-13 13:38 ` [PATCHv4 6/6] usb: gadget: f_mass_storage: Fix a warning while loading g_mass_storage Michal Nazarewicz
2014-06-13 14:22 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402666689-4971-3-git-send-email-mina86@mina86.com \
--to=mina86@mina86.com \
--cc=balbi@ti.com \
--cc=k.opasiak@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®