mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Fjodor Schelichow <fjodor.schelichow@hotmail.com>
Cc: Evgeniy Polyakov <zbr@ioremap.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	David Fries <David@Fries.net>,
	Michael Opdenacker <michael.opdenacker@free-electrons.com>,
	Jingoo Han <jg1.han@samsung.com>,
	linux-kernel@vger.kernel.org, Roman Sommer <romsom2@yahoo.de>,
	linux-kernel@i4.cs.fau.de
Subject: Re: [PATCH 2/3] w1: use pr_* instead of printk
Date: Wed, 18 Jun 2014 18:07:13 -0700	[thread overview]
Message-ID: <1403140033.14018.12.camel@joe-AO725> (raw)
In-Reply-To: <1403139121-2431-3-git-send-email-fjodor.schelichow@hotmail.com>

On Thu, 2014-06-19 at 02:52 +0200, Fjodor Schelichow wrote:
> This patch replaces all calls to the "printk" function within the main "w1"
> directory by calls to the appropriate "pr_*" function thus addressing
> the following warning generated by the checkpatch script:
[]
> diff --git a/drivers/w1/w1_log.h b/drivers/w1/w1_log.h
[]
> @@ -29,8 +29,8 @@
>  #else
>  #  define assert(expr) \
>          if(unlikely(!(expr))) {				        \
> -        printk(KERN_ERR "Assertion failed! %s,%s,%s,line=%d\n",	\
> -	#expr, __FILE__, __func__, __LINE__);		        \
> +		pr_err("Assertion failed! %s,%s,%s,line=%d\n",	\
> +		#expr, __FILE__, __func__, __LINE__);		\
>          }

These macros should really be surrounded by a do { ... } while (0)



  reply	other threads:[~2014-06-19  1:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-19  0:51 [PATCH 0/3] "printk" related fixes for the 1-wire (w1) subsystem Fjodor Schelichow
2014-06-19  0:51 ` [PATCH 1/3] w1/slaves: use pr_* instead of printk Fjodor Schelichow
2014-06-19  0:52 ` [PATCH 2/3] w1: " Fjodor Schelichow
2014-06-19  1:07   ` Joe Perches [this message]
2014-06-19  0:52 ` [PATCH 3/3] w1/masters: " Fjodor Schelichow
2014-06-19 18:19 ` [PATCH 0/3] "printk" related fixes for the 1-wire (w1) subsystem Evgeniy Polyakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1403140033.14018.12.camel@joe-AO725 \
    --to=joe@perches.com \
    --cc=David@Fries.net \
    --cc=fjodor.schelichow@hotmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jg1.han@samsung.com \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.opdenacker@free-electrons.com \
    --cc=romsom2@yahoo.de \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®