From: Michal Nazarewicz <mina86@mina86.com>
To: Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Michal Nazarewicz <mina86@mina86.com>
Subject: [PATCH] x86: tsc: get rid of custom DIV_ROUND
Date: Thu, 19 Jun 2014 03:58:36 +0200 [thread overview]
Message-ID: <1403143116-21755-1-git-send-email-mina86@mina86.com> (raw)
When invoced for positive values, DIV_ROUND macro defined in
arch/x86/kernel/tsc.c behaves exactly like DIV_ROUND_CLOSEST from
include/linux/kernel.h file, so remove the custom macro in favour
of the shared one.
Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
---
arch/x86/kernel/tsc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
No changes after compilation:
$ ll tsc.o.*
-rw------- 1 mpn eng 46497 Jun 19 03:54 tsc.o.after
-rw------- 1 mpn eng 46497 Jun 19 03:55 tsc.o.before
$ objdump -d tsc.o.before >tsc.s.before
$ objdump -d tsc.o.after >tsc.s.after
$ diff -u tsc.s.before tsc.s.after
--- tsc.s.before 2014-06-19 03:56:54.880545041 +0200
+++ tsc.s.after 2014-06-19 03:56:54.884545079 +0200
@@ -1,5 +1,5 @@
-tsc.o.before: file format elf64-x86-64
+tsc.o.after: file format elf64-x86-64
Disassembly of section .text:
$
diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 57e5ce1..02f21c0 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -234,9 +234,6 @@ static inline unsigned long long cycles_2_ns(unsigned long long cyc)
return ns;
}
-/* XXX surely we already have this someplace in the kernel?! */
-#define DIV_ROUND(n, d) (((n) + ((d) / 2)) / (d))
-
static void set_cyc2ns_scale(unsigned long cpu_khz, int cpu)
{
unsigned long long tsc_now, ns_now;
@@ -259,7 +256,8 @@ static void set_cyc2ns_scale(unsigned long cpu_khz, int cpu)
* time function is continuous; see the comment near struct
* cyc2ns_data.
*/
- data->cyc2ns_mul = DIV_ROUND(NSEC_PER_MSEC << CYC2NS_SCALE_FACTOR, cpu_khz);
+ data->cyc2ns_mul = DIV_ROUND_CLOSEST(
+ NSEC_PER_MSEC << CYC2NS_SCALE_FACTOR, cpu_khz);
data->cyc2ns_shift = CYC2NS_SCALE_FACTOR;
data->cyc2ns_offset = ns_now -
mul_u64_u32_shr(tsc_now, data->cyc2ns_mul, CYC2NS_SCALE_FACTOR);
--
2.0.0.526.g5318336
next reply other threads:[~2014-06-19 1:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 1:58 Michal Nazarewicz [this message]
2014-06-19 2:19 ` David Rientjes
2014-06-20 5:12 ` [tip:x86/cleanups] x86/tsc: Get rid of custom DIV_ROUND() macro tip-bot for Michal Nazarewicz
2014-06-23 9:18 ` [PATCH] x86: tsc: get rid of custom DIV_ROUND Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1403143116-21755-1-git-send-email-mina86@mina86.com \
--to=mina86@mina86.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®