From: Peter Zijlstra <peterz@infradead.org>
To: Michal Nazarewicz <mina86@mina86.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: tsc: get rid of custom DIV_ROUND
Date: Mon, 23 Jun 2014 11:18:18 +0200 [thread overview]
Message-ID: <20140623091818.GO19860@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <1403143116-21755-1-git-send-email-mina86@mina86.com>
On Thu, Jun 19, 2014 at 03:58:36AM +0200, Michal Nazarewicz wrote:
> When invoced for positive values, DIV_ROUND macro defined in
> arch/x86/kernel/tsc.c behaves exactly like DIV_ROUND_CLOSEST from
> include/linux/kernel.h file, so remove the custom macro in favour
> of the shared one.
See, I knew we'd had one. _CLOSEST is a dumb postfix though, its the
default whenever people talk of rounding.
> Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
> ---
> arch/x86/kernel/tsc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> No changes after compilation:
>
> $ ll tsc.o.*
> -rw------- 1 mpn eng 46497 Jun 19 03:54 tsc.o.after
> -rw------- 1 mpn eng 46497 Jun 19 03:55 tsc.o.before
> $ objdump -d tsc.o.before >tsc.s.before
> $ objdump -d tsc.o.after >tsc.s.after
> $ diff -u tsc.s.before tsc.s.after
> --- tsc.s.before 2014-06-19 03:56:54.880545041 +0200
> +++ tsc.s.after 2014-06-19 03:56:54.884545079 +0200
> @@ -1,5 +1,5 @@
>
> -tsc.o.before: file format elf64-x86-64
> +tsc.o.after: file format elf64-x86-64
>
>
> Disassembly of section .text:
> $
This diff in a diff totally confused patch.
Applies when I remove that.
prev parent reply other threads:[~2014-06-23 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 1:58 Michal Nazarewicz
2014-06-19 2:19 ` David Rientjes
2014-06-20 5:12 ` [tip:x86/cleanups] x86/tsc: Get rid of custom DIV_ROUND() macro tip-bot for Michal Nazarewicz
2014-06-23 9:18 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140623091818.GO19860@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome