* [PATCH] checkpatch: Ignore email headers better
@ 2014-06-20 5:22 Joe Perches
0 siblings, 0 replies; only message in thread
From: Joe Perches @ 2014-06-20 5:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: Andy Whitcroft, LKML
There are some patches created by git format-patch
that when scanned by checkpatch report errors on
lines like
To: address.tld
This is a checkpatch false positive.
Improve the logic a bit to ignore folded email headers
to avoid emitting these messages.
Signed-off-by: Joe Perches <joe@perches.com>
---
scripts/checkpatch.pl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index dd845b9..1e17de2 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1637,7 +1637,7 @@ sub process {
my $signoff = 0;
my $is_patch = 0;
- my $in_header_lines = 1;
+ my $in_header_lines = $file ? 0 : 1;
my $in_commit_log = 0; #Scanning lines before patch
my $non_utf8_charset = 0;
@@ -1993,7 +1993,8 @@ sub process {
# Check if it's the start of a commit log
# (not a header line and we haven't seen the patch filename)
if ($in_header_lines && $realfile =~ /^$/ &&
- $rawline !~ /^(commit\b|from\b|[\w-]+:).+$/i) {
+ !($rawline =~ /^\s+\S/ ||
+ $rawline =~ /^(commit\b|from\b|[\w-]+:).*$/i)) {
$in_header_lines = 0;
$in_commit_log = 1;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-06-20 5:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-20 5:22 [PATCH] checkpatch: Ignore email headers better Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®