* [PATCH] serial: samsung: Remove redundant label
@ 2014-06-23 6:02 Tushar Behera
2014-06-23 6:12 ` Sachin Kamat
0 siblings, 1 reply; 2+ messages in thread
From: Tushar Behera @ 2014-06-23 6:02 UTC (permalink / raw)
To: linux-kernel, linux-serial; +Cc: jslaby, gregkh
probe_err label only returns the error code. This label can be removed
and the error code can be returned directly.
Signed-off-by: Tushar Behera <tushar.b@samsung.com>
---
drivers/tty/serial/samsung.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index c1d3ebd..bf93010 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -1303,7 +1303,7 @@ static int s3c24xx_serial_probe(struct platform_device *pdev)
ret = s3c24xx_serial_init_port(ourport, pdev);
if (ret < 0)
- goto probe_err;
+ return ret;
if (!s3c24xx_uart_drv.state) {
ret = uart_register_driver(&s3c24xx_uart_drv);
@@ -1335,9 +1335,6 @@ static int s3c24xx_serial_probe(struct platform_device *pdev)
dev_err(&pdev->dev, "failed to add cpufreq notifier\n");
return 0;
-
- probe_err:
- return ret;
}
static int s3c24xx_serial_remove(struct platform_device *dev)
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] serial: samsung: Remove redundant label
2014-06-23 6:02 [PATCH] serial: samsung: Remove redundant label Tushar Behera
@ 2014-06-23 6:12 ` Sachin Kamat
0 siblings, 0 replies; 2+ messages in thread
From: Sachin Kamat @ 2014-06-23 6:12 UTC (permalink / raw)
To: Tushar Behera; +Cc: open list, linux-serial, Jiri Slaby, Greg Kroah-Hartman
On Mon, Jun 23, 2014 at 11:32 AM, Tushar Behera <tushar.b@samsung.com> wrote:
> probe_err label only returns the error code. This label can be removed
> and the error code can be returned directly.
>
> Signed-off-by: Tushar Behera <tushar.b@samsung.com>
> ---
> drivers/tty/serial/samsung.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index c1d3ebd..bf93010 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -1303,7 +1303,7 @@ static int s3c24xx_serial_probe(struct platform_device *pdev)
>
> ret = s3c24xx_serial_init_port(ourport, pdev);
> if (ret < 0)
> - goto probe_err;
> + return ret;
>
> if (!s3c24xx_uart_drv.state) {
> ret = uart_register_driver(&s3c24xx_uart_drv);
> @@ -1335,9 +1335,6 @@ static int s3c24xx_serial_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "failed to add cpufreq notifier\n");
>
> return 0;
> -
> - probe_err:
> - return ret;
> }
>
> static int s3c24xx_serial_remove(struct platform_device *dev)
> --
Looks good.
Reviewed-by: Sachin Kamat <sachin.kamat@samsung.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-23 6:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-23 6:02 [PATCH] serial: samsung: Remove redundant label Tushar Behera
2014-06-23 6:12 ` Sachin Kamat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®