* [PATCH] perf: fix arm64 build error
@ 2014-06-25 3:16 Mark Salter
2014-06-25 8:12 ` Jean Pihet
0 siblings, 1 reply; 3+ messages in thread
From: Mark Salter @ 2014-06-25 3:16 UTC (permalink / raw)
To: linux-kernel
Cc: Peter Zijlstra, Paul Mackerras, Ingo Molnar,
Arnaldo Carvalho de Melo, Jean Pihet, Mark Salter
I'm seeing the following build error on arm64:
In file included from util/event.c:3:0:
util/event.h:95:17: error: 'PERF_REGS_MAX' undeclared here (not in a function)
u64 cache_regs[PERF_REGS_MAX];
^
This patch adds a PEFF_REGS_MAX definition for arm64.
Signed-off-by: Mark Salter <msalter@redhat.com>
---
tools/perf/arch/arm64/include/perf_regs.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf/arch/arm64/include/perf_regs.h b/tools/perf/arch/arm64/include/perf_regs.h
index e9441b9..1d3f39c 100644
--- a/tools/perf/arch/arm64/include/perf_regs.h
+++ b/tools/perf/arch/arm64/include/perf_regs.h
@@ -6,6 +6,8 @@
#include <asm/perf_regs.h>
#define PERF_REGS_MASK ((1ULL << PERF_REG_ARM64_MAX) - 1)
+#define PERF_REGS_MAX PERF_REG_ARM64_MAX
+
#define PERF_REG_IP PERF_REG_ARM64_PC
#define PERF_REG_SP PERF_REG_ARM64_SP
--
1.9.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf: fix arm64 build error
2014-06-25 3:16 [PATCH] perf: fix arm64 build error Mark Salter
@ 2014-06-25 8:12 ` Jean Pihet
2014-06-25 14:13 ` Mark Salter
0 siblings, 1 reply; 3+ messages in thread
From: Jean Pihet @ 2014-06-25 8:12 UTC (permalink / raw)
To: Mark Salter
Cc: linux-kernel, Peter Zijlstra, Paul Mackerras, Ingo Molnar,
Arnaldo Carvalho de Melo
Hi Mark,
On 25 June 2014 05:16, Mark Salter <msalter@redhat.com> wrote:
> I'm seeing the following build error on arm64:
>
> In file included from util/event.c:3:0:
> util/event.h:95:17: error: 'PERF_REGS_MAX' undeclared here (not in a function)
> u64 cache_regs[PERF_REGS_MAX];
> ^
>
> This patch adds a PEFF_REGS_MAX definition for arm64.
s/PEFF_REGS_MAX/PERF_REGS_MAX
>
> Signed-off-by: Mark Salter <msalter@redhat.com>
Acked-by: Jean Pihet <jean.pihet@linaro.org>
Thanks!
Note: Do you have any performance figure with and without the caching
code in perf?
Jean
> ---
> tools/perf/arch/arm64/include/perf_regs.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/arch/arm64/include/perf_regs.h b/tools/perf/arch/arm64/include/perf_regs.h
> index e9441b9..1d3f39c 100644
> --- a/tools/perf/arch/arm64/include/perf_regs.h
> +++ b/tools/perf/arch/arm64/include/perf_regs.h
> @@ -6,6 +6,8 @@
> #include <asm/perf_regs.h>
>
> #define PERF_REGS_MASK ((1ULL << PERF_REG_ARM64_MAX) - 1)
> +#define PERF_REGS_MAX PERF_REG_ARM64_MAX
> +
> #define PERF_REG_IP PERF_REG_ARM64_PC
> #define PERF_REG_SP PERF_REG_ARM64_SP
>
> --
> 1.9.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf: fix arm64 build error
2014-06-25 8:12 ` Jean Pihet
@ 2014-06-25 14:13 ` Mark Salter
0 siblings, 0 replies; 3+ messages in thread
From: Mark Salter @ 2014-06-25 14:13 UTC (permalink / raw)
To: Jean Pihet
Cc: linux-kernel, Peter Zijlstra, Paul Mackerras, Ingo Molnar,
Arnaldo Carvalho de Melo
On Wed, 2014-06-25 at 10:12 +0200, Jean Pihet wrote:
> Hi Mark,
>
> On 25 June 2014 05:16, Mark Salter <msalter@redhat.com> wrote:
> > I'm seeing the following build error on arm64:
> >
> > In file included from util/event.c:3:0:
> > util/event.h:95:17: error: 'PERF_REGS_MAX' undeclared here (not in a function)
> > u64 cache_regs[PERF_REGS_MAX];
> > ^
> >
> > This patch adds a PEFF_REGS_MAX definition for arm64.
> s/PEFF_REGS_MAX/PERF_REGS_MAX
>
> >
> > Signed-off-by: Mark Salter <msalter@redhat.com>
>
> Acked-by: Jean Pihet <jean.pihet@linaro.org>
>
> Thanks!
>
> Note: Do you have any performance figure with and without the caching
> code in perf?
Sorry, I don't.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-25 14:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-25 3:16 [PATCH] perf: fix arm64 build error Mark Salter
2014-06-25 8:12 ` Jean Pihet
2014-06-25 14:13 ` Mark Salter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®