* [PATCH 1/2] staging: wlan-ng/hfa384x_usb.c: remove return statements for void function
@ 2014-06-25 15:24 Cheng-Wei Lee
2014-06-25 15:28 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Cheng-Wei Lee @ 2014-06-25 15:24 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sherif Shehab Aldin, Avinash Kumar,
Peter Senna Tschudin
Cc: devel, linux-kernel
This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
WARNING: void function return statements are not generally useful
Signed-off-by: Quentin Lee <lee.rhapsody@gmail.com>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
b/drivers/staging/wlan-ng/hfa384x_usb.c
index 98343ff7..07cee56 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -3705,6 +3705,7 @@ static void hfa384x_usbout_callback(struct urb *urb)
case -EPIPE:
{
hfa384x_t *hw = wlandev->priv;
+
netdev_warn(hw->wlandev->netdev,
"%s tx pipe stalled: requesting reset\n",
wlandev->netdev->name);
--
1.7.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] staging: wlan-ng/hfa384x_usb.c: remove return statements for void function
2014-06-25 15:24 [PATCH 1/2] staging: wlan-ng/hfa384x_usb.c: remove return statements for void function Cheng-Wei Lee
@ 2014-06-25 15:28 ` Joe Perches
2014-06-25 15:37 ` Cheng-Wei Lee
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2014-06-25 15:28 UTC (permalink / raw)
To: Cheng-Wei Lee
Cc: Greg Kroah-Hartman, Sherif Shehab Aldin, Avinash Kumar,
Peter Senna Tschudin, devel, linux-kernel
On Wed, 2014-06-25 at 23:24 +0800, Cheng-Wei Lee wrote:
> This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
> WARNING: void function return statements are not generally useful
subject/code mismatch.
> Signed-off-by: Quentin Lee <lee.rhapsody@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
> b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 98343ff7..07cee56 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -3705,6 +3705,7 @@ static void hfa384x_usbout_callback(struct urb *urb)
> case -EPIPE:
> {
> hfa384x_t *hw = wlandev->priv;
> +
> netdev_warn(hw->wlandev->netdev,
> "%s tx pipe stalled: requesting reset\n",
> wlandev->netdev->name);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] staging: wlan-ng/hfa384x_usb.c: remove return statements for void function
2014-06-25 15:28 ` Joe Perches
@ 2014-06-25 15:37 ` Cheng-Wei Lee
0 siblings, 0 replies; 3+ messages in thread
From: Cheng-Wei Lee @ 2014-06-25 15:37 UTC (permalink / raw)
To: Joe Perches
Cc: Greg Kroah-Hartman, Sherif Shehab Aldin, Avinash Kumar,
Peter Senna Tschudin, devel, linux-kernel
Dear all,
Thanks Joe's reminder. I've resent patch.
Sincerely,
Quentin
2014-06-25 23:28 GMT+08:00, Joe Perches <joe@perches.com>:
> On Wed, 2014-06-25 at 23:24 +0800, Cheng-Wei Lee wrote:
>> This patch fixes the following checkpatch.pl issues in hfa384x_usb.c:
>> WARNING: void function return statements are not generally useful
>
> subject/code mismatch.
>
>> Signed-off-by: Quentin Lee <lee.rhapsody@gmail.com>
>> ---
>> drivers/staging/wlan-ng/hfa384x_usb.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c
>> b/drivers/staging/wlan-ng/hfa384x_usb.c
>> index 98343ff7..07cee56 100644
>> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
>> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
>> @@ -3705,6 +3705,7 @@ static void hfa384x_usbout_callback(struct urb
>> *urb)
>> case -EPIPE:
>> {
>> hfa384x_t *hw = wlandev->priv;
>> +
>> netdev_warn(hw->wlandev->netdev,
>> "%s tx pipe stalled: requesting reset\n",
>> wlandev->netdev->name);
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-25 15:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-25 15:24 [PATCH 1/2] staging: wlan-ng/hfa384x_usb.c: remove return statements for void function Cheng-Wei Lee
2014-06-25 15:28 ` Joe Perches
2014-06-25 15:37 ` Cheng-Wei Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®