From: Joe Lawrence <joe.lawrence@stratus.com>
To: <linux-kernel@vger.kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, Jiri Kosina <jkosina@suse.cz>,
Jeff Moyer <jmoyer@redhat.com>,
Boaz Harrosh <bharrosh@panasas.com>,
Joe Lawrence <joe.lawrence@stratus.com>
Subject: [PATCH v3 0/2] block,scsi: fixup blk_get_request dead queue scenarios
Date: Wed, 2 Jul 2014 15:35:15 -0400 [thread overview]
Message-ID: <1404329718-19367-1-git-send-email-joe.lawrence@stratus.com> (raw)
v2->v3: rebase to 3.16-rc2, consider return values from the
blk_mq_alloc_request leg of the blk_get_request callchain
(noted by Jeff), noted in the second patch changelog.
blk_mq_queue_enter may return 0 or errno, which
blk_mq_alloc_request can propogate out via ERR_PTR.
__blk_mq_alloc_request doesn't include any blk_queue_dying
checks, so I'm assuming that its failures can be attributed
to -EWOULDBLOCK under !GFP_WAIT conditions.
v1->v2: incorporate Jeff's feedback in bsg_map_hdr() and Reviewed-by
tags.
Joe Lawrence (2):
block,scsi: verify return pointer from blk_get_request
block,scsi: fixup blk_get_request dead queue scenarios
block/blk-core.c | 34 +++++++++++++--------------
block/blk-mq.c | 8 +++++--
block/bsg.c | 8 +++----
block/scsi_ioctl.c | 13 +++++++---
drivers/block/paride/pd.c | 2 ++
drivers/block/pktcdvd.c | 2 ++
drivers/block/sx8.c | 2 +-
drivers/cdrom/cdrom.c | 4 ++--
drivers/ide/ide-park.c | 2 +-
drivers/scsi/device_handler/scsi_dh_alua.c | 2 +-
drivers/scsi/device_handler/scsi_dh_emc.c | 2 +-
drivers/scsi/device_handler/scsi_dh_hp_sw.c | 4 ++--
drivers/scsi/device_handler/scsi_dh_rdac.c | 2 +-
drivers/scsi/osd/osd_initiator.c | 4 ++--
drivers/scsi/osst.c | 2 +-
drivers/scsi/scsi_error.c | 2 ++
drivers/scsi/scsi_lib.c | 2 +-
drivers/scsi/scsi_tgt_lib.c | 2 +-
drivers/scsi/sg.c | 4 ++--
drivers/scsi/st.c | 2 +-
drivers/target/target_core_pscsi.c | 2 +-
21 files changed, 61 insertions(+), 44 deletions(-)
--
1.7.10.4
next reply other threads:[~2014-07-02 19:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 19:35 Joe Lawrence [this message]
2014-07-02 19:35 ` [PATCH v3 1/2] block,scsi: verify return pointer from blk_get_request Joe Lawrence
2014-07-02 19:35 ` [PATCH v3 2/2] block,scsi: fixup blk_get_request dead queue scenarios Joe Lawrence
2014-07-02 20:26 ` [PATCH v3 0/2] " Joe Lawrence
2014-08-26 17:24 ` Jeff Moyer
2014-08-26 21:19 ` Jens Axboe
2014-08-26 21:24 ` Jens Axboe
2014-08-26 21:27 ` Jeff Moyer
2014-08-26 21:33 ` Jens Axboe
2014-08-26 21:37 ` Jens Axboe
2014-08-26 22:01 ` Jeff Moyer
2014-08-27 14:07 ` Jens Axboe
2014-08-27 15:33 ` Joe Lawrence
2014-08-27 15:50 ` Boaz Harrosh
2014-08-27 16:05 ` Jens Axboe
2014-08-27 14:13 ` Joe Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404329718-19367-1-git-send-email-joe.lawrence@stratus.com \
--to=joe.lawrence@stratus.com \
--cc=axboe@kernel.dk \
--cc=bharrosh@panasas.com \
--cc=jkosina@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®