From: Jeff Moyer <jmoyer@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Joe Lawrence <joe.lawrence@stratus.com>,
linux-kernel@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>,
Boaz Harrosh <bharrosh@panasas.com>
Subject: Re: [PATCH v3 0/2] block,scsi: fixup blk_get_request dead queue scenarios
Date: Tue, 26 Aug 2014 18:01:23 -0400 [thread overview]
Message-ID: <x49iole6hcc.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <53FCFE01.8080701@kernel.dk> (Jens Axboe's message of "Tue, 26 Aug 2014 15:37:05 -0600")
Jens Axboe <axboe@kernel.dk> writes:
>> I have applied the first one, will look over the second one and hand
>> apply it. Seems the NULL return was completely removed, so we _should_
>> be ok on the IS_ERR() conversion, though that sort of thing always
>> worries me a little bit. A NULL return can quickly show up again, and
>> then they would all fail.
Well, we could guard against that with a BUG_ON in blk_get_request,
right?
> Additionally, there's still quite a few places that call
> blk_get_request() and don't check the error return if __GFP_WAIT is set.
> Since most of the point of this is to fix segfaulting on queue dead
> scenarios, why aren't they all converted?
Odd, I thought they all were converted last I checked. They definitely
should be.
-Jeff
next prev parent reply other threads:[~2014-08-26 22:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 19:35 Joe Lawrence
2014-07-02 19:35 ` [PATCH v3 1/2] block,scsi: verify return pointer from blk_get_request Joe Lawrence
2014-07-02 19:35 ` [PATCH v3 2/2] block,scsi: fixup blk_get_request dead queue scenarios Joe Lawrence
2014-07-02 20:26 ` [PATCH v3 0/2] " Joe Lawrence
2014-08-26 17:24 ` Jeff Moyer
2014-08-26 21:19 ` Jens Axboe
2014-08-26 21:24 ` Jens Axboe
2014-08-26 21:27 ` Jeff Moyer
2014-08-26 21:33 ` Jens Axboe
2014-08-26 21:37 ` Jens Axboe
2014-08-26 22:01 ` Jeff Moyer [this message]
2014-08-27 14:07 ` Jens Axboe
2014-08-27 15:33 ` Joe Lawrence
2014-08-27 15:50 ` Boaz Harrosh
2014-08-27 16:05 ` Jens Axboe
2014-08-27 14:13 ` Joe Lawrence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49iole6hcc.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@kernel.dk \
--cc=bharrosh@panasas.com \
--cc=jkosina@suse.cz \
--cc=joe.lawrence@stratus.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®