* [PATCH] mach-omap2: Change if statement in omap2_dflt_clk_enable
@ 2014-07-04 21:04 Nicholas Krause
2014-07-05 5:37 ` Paul Walmsley
0 siblings, 1 reply; 2+ messages in thread
From: Nicholas Krause @ 2014-07-04 21:04 UTC (permalink / raw)
To: paul; +Cc: tony, linux, linux-omap, linux-arm-kernel, linux-kernel
This patch changes this function to check for if v is returning value from the
called function. If not it does the else. Furthermore fixes the FIXME message above
if statement for holding INVERT_ENABLE bit when not needing to be checked for
in if statement by just checking for if v is not Null.
Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
arch/arm/mach-omap2/clock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
index 591581a..626363d 100644
--- a/arch/arm/mach-omap2/clock.c
+++ b/arch/arm/mach-omap2/clock.c
@@ -379,7 +379,7 @@ void omap2_dflt_clk_disable(struct clk_hw *hw)
}
v = omap2_clk_readl(clk, clk->enable_reg);
- if (clk->flags & INVERT_ENABLE)
+ if (v)
v |= (1 << clk->enable_bit);
else
v &= ~(1 << clk->enable_bit);
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mach-omap2: Change if statement in omap2_dflt_clk_enable
2014-07-04 21:04 [PATCH] mach-omap2: Change if statement in omap2_dflt_clk_enable Nicholas Krause
@ 2014-07-05 5:37 ` Paul Walmsley
0 siblings, 0 replies; 2+ messages in thread
From: Paul Walmsley @ 2014-07-05 5:37 UTC (permalink / raw)
To: Nicholas Krause; +Cc: tony, linux, linux-omap, linux-arm-kernel, linux-kernel
On Fri, 4 Jul 2014, Nicholas Krause wrote:
> This patch changes this function to check for if v is returning value from the
> called function. If not it does the else. Furthermore fixes the FIXME message above
> if statement for holding INVERT_ENABLE bit when not needing to be checked for
> in if statement by just checking for if v is not Null.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
This patch doesn't make any sense. Neither does the commit message.
Please explain exactly what this patch is intended to do in terms of the
clock framework or the hardware.
- Paul
> ---
> arch/arm/mach-omap2/clock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
> index 591581a..626363d 100644
> --- a/arch/arm/mach-omap2/clock.c
> +++ b/arch/arm/mach-omap2/clock.c
> @@ -379,7 +379,7 @@ void omap2_dflt_clk_disable(struct clk_hw *hw)
> }
>
> v = omap2_clk_readl(clk, clk->enable_reg);
> - if (clk->flags & INVERT_ENABLE)
> + if (v)
> v |= (1 << clk->enable_bit);
> else
> v &= ~(1 << clk->enable_bit);
> --
> 1.9.1
>
- Paul
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-05 5:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-04 21:04 [PATCH] mach-omap2: Change if statement in omap2_dflt_clk_enable Nicholas Krause
2014-07-05 5:37 ` Paul Walmsley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®