From: Joe Perches <joe@perches.com>
To: Fabio Falzoi <fabio.falzoi84@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, wei_wang@realsil.com.cn,
micky_ching@realsil.com.cn
Subject: Re: [PATCH 2/4] Staging: rts5208: Use standard print_hex_dump_debug
Date: Sun, 06 Jul 2014 09:23:07 -0700 [thread overview]
Message-ID: <1404663787.27043.33.camel@joe-AO725> (raw)
In-Reply-To: <1404663138-21333-3-git-send-email-fabio.falzoi84@gmail.com>
On Sun, 2014-07-06 at 18:12 +0200, Fabio Falzoi wrote:
> Use print_hex_dump_debug to have memory properly dumped only when dynamic
> debug is enabled.
Not true.
Now it prints all the time when !CONFIG_DYNAMIC_DEBUG
and CONFIG_PRINTK.
> diff --git a/drivers/staging/rts5208/trace.h b/drivers/staging/rts5208/trace.h
[]
> -#ifdef CONFIG_RTS5208_DEBUG
> -#define RTSX_DUMP(buf, buf_len) \
> - print_hex_dump(KERN_DEBUG, KBUILD_MODNAME ": ", \
> - DUMP_PREFIX_NONE, 16, 1, (buf), (buf_len), false)
> -#else
> -#define RTSX_DUMP(buf, buf_len)
> -#endif
> -
> #endif /* __REALTEK_RTSX_TRACE_H */
Before it would not print at all if !CONFIG_RTS5208_DEBUG.
next prev parent reply other threads:[~2014-07-06 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-06 16:12 [PATCH 0/4] Staging: rts5208: Use dynamic debug feature Fabio Falzoi
2014-07-06 16:12 ` [PATCH 1/4] Staging: rts5208: Use standard pr_debug macro Fabio Falzoi
2014-07-06 16:12 ` [PATCH 2/4] Staging: rts5208: Use standard print_hex_dump_debug Fabio Falzoi
2014-07-06 16:23 ` Joe Perches [this message]
2014-07-06 16:32 ` Fabio Falzoi
2014-07-06 16:39 ` Joe Perches
2014-07-06 16:12 ` [PATCH 3/4] Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option Fabio Falzoi
2014-07-06 16:12 ` [PATCH 4/4] Staging: rts5208: Fix a format specifier for dev_err Fabio Falzoi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404663787.27043.33.camel@joe-AO725 \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.falzoi84@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®