From: Joe Perches <joe@perches.com>
To: Fabio Falzoi <fabio.falzoi84@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, wei_wang@realsil.com.cn,
micky_ching@realsil.com.cn
Subject: Re: [PATCH 2/4] Staging: rts5208: Use standard print_hex_dump_debug
Date: Sun, 06 Jul 2014 09:39:59 -0700 [thread overview]
Message-ID: <1404664799.27043.41.camel@joe-AO725> (raw)
In-Reply-To: <CACar8Ln_8+EQGf8z7kNqRPxOcheUuKj5bOg3TJ+xTF_SQFVGQQ@mail.gmail.com>
On Sun, 2014-07-06 at 18:32 +0200, Fabio Falzoi wrote:
> Have I to fix just the commit message or is this behaviour not suitable?
> In the latter case, could you please suggest a way to fix this?
Hi Fabio.
I think it's not appropriate.
I'd've changed it to something like:
#if DEBUG
#define rtsx_hex_dump(buf, len) \
print_hex_dump_bytes(KBUILD_MODNAME ": ", DUMP_PREFIX_NONE, \
buf, len)
#else
#define rtsx_hex_dump(buf, len)
do {;} while (0)
#endif
next prev parent reply other threads:[~2014-07-06 16:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-06 16:12 [PATCH 0/4] Staging: rts5208: Use dynamic debug feature Fabio Falzoi
2014-07-06 16:12 ` [PATCH 1/4] Staging: rts5208: Use standard pr_debug macro Fabio Falzoi
2014-07-06 16:12 ` [PATCH 2/4] Staging: rts5208: Use standard print_hex_dump_debug Fabio Falzoi
2014-07-06 16:23 ` Joe Perches
2014-07-06 16:32 ` Fabio Falzoi
2014-07-06 16:39 ` Joe Perches [this message]
2014-07-06 16:12 ` [PATCH 3/4] Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option Fabio Falzoi
2014-07-06 16:12 ` [PATCH 4/4] Staging: rts5208: Fix a format specifier for dev_err Fabio Falzoi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404664799.27043.41.camel@joe-AO725 \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.falzoi84@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®