* [PATCH] cpufreq: Makefile: fix compilation for davinci platform
@ 2014-07-08 15:25 Lad, Prabhakar
2014-07-08 15:29 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Lad, Prabhakar @ 2014-07-08 15:25 UTC (permalink / raw)
To: Viresh Kumar, linux-kernel, linux-pm, Rafael J. Wysocki
Cc: Sekhar Nori, davinci-linux-open-source, Lad, Prabhakar
>From patch with commt-id:8a7b1227e303d7e927214ee0f260041aef44bb58
"cpufreq: davinci: move cpufreq driver to drivers/cpufreq"
this added dependancy only for CONFIG_ARCH_DAVINCI_DA850 where as
davinci_cpufreq_init() call is used by all davinci platform.
This patch fixes following build error:
arch/arm/mach-davinci/built-in.o: In function `davinci_init_late':
:(.init.text+0x928): undefined reference to `davinci_cpufreq_init'
make: *** [vmlinux] Error 1
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
drivers/cpufreq/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
index 738c8b7..db6d9a2 100644
--- a/drivers/cpufreq/Makefile
+++ b/drivers/cpufreq/Makefile
@@ -49,7 +49,7 @@ obj-$(CONFIG_ARM_BIG_LITTLE_CPUFREQ) += arm_big_little.o
# LITTLE drivers, so that it is probed last.
obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
-obj-$(CONFIG_ARCH_DAVINCI_DA850) += davinci-cpufreq.o
+obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += exynos-cpufreq.o
obj-$(CONFIG_ARM_EXYNOS4210_CPUFREQ) += exynos4210-cpufreq.o
--
1.9.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: Makefile: fix compilation for davinci platform
2014-07-08 15:25 [PATCH] cpufreq: Makefile: fix compilation for davinci platform Lad, Prabhakar
@ 2014-07-08 15:29 ` Viresh Kumar
2014-07-08 15:32 ` Prabhakar Lad
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2014-07-08 15:29 UTC (permalink / raw)
To: Lad, Prabhakar
Cc: Linux Kernel Mailing List, linux-pm, Rafael J. Wysocki,
Sekhar Nori, davinci-linux-open-source
On 8 July 2014 20:55, Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote:
> From patch with commt-id:8a7b1227e303d7e927214ee0f260041aef44bb58
> "cpufreq: davinci: move cpufreq driver to drivers/cpufreq"
> this added dependancy only for CONFIG_ARCH_DAVINCI_DA850 where as
> davinci_cpufreq_init() call is used by all davinci platform.
>
> This patch fixes following build error:
>
> arch/arm/mach-davinci/built-in.o: In function `davinci_init_late':
> :(.init.text+0x928): undefined reference to `davinci_cpufreq_init'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> ---
> drivers/cpufreq/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> index 738c8b7..db6d9a2 100644
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> @@ -49,7 +49,7 @@ obj-$(CONFIG_ARM_BIG_LITTLE_CPUFREQ) += arm_big_little.o
> # LITTLE drivers, so that it is probed last.
> obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
>
> -obj-$(CONFIG_ARCH_DAVINCI_DA850) += davinci-cpufreq.o
> +obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
> obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
> obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += exynos-cpufreq.o
> obj-$(CONFIG_ARM_EXYNOS4210_CPUFREQ) += exynos4210-cpufreq.o
It took one year and 5 kernel releases to catch this again?
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: Makefile: fix compilation for davinci platform
2014-07-08 15:29 ` Viresh Kumar
@ 2014-07-08 15:32 ` Prabhakar Lad
0 siblings, 0 replies; 3+ messages in thread
From: Prabhakar Lad @ 2014-07-08 15:32 UTC (permalink / raw)
To: Viresh Kumar
Cc: Linux Kernel Mailing List, linux-pm, Rafael J. Wysocki,
Sekhar Nori, dlos
On Tue, Jul 8, 2014 at 4:29 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 8 July 2014 20:55, Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote:
>> From patch with commt-id:8a7b1227e303d7e927214ee0f260041aef44bb58
>> "cpufreq: davinci: move cpufreq driver to drivers/cpufreq"
>> this added dependancy only for CONFIG_ARCH_DAVINCI_DA850 where as
>> davinci_cpufreq_init() call is used by all davinci platform.
>>
>> This patch fixes following build error:
>>
>> arch/arm/mach-davinci/built-in.o: In function `davinci_init_late':
>> :(.init.text+0x928): undefined reference to `davinci_cpufreq_init'
>> make: *** [vmlinux] Error 1
>>
>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>> ---
>> drivers/cpufreq/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
>> index 738c8b7..db6d9a2 100644
>> --- a/drivers/cpufreq/Makefile
>> +++ b/drivers/cpufreq/Makefile
>> @@ -49,7 +49,7 @@ obj-$(CONFIG_ARM_BIG_LITTLE_CPUFREQ) += arm_big_little.o
>> # LITTLE drivers, so that it is probed last.
>> obj-$(CONFIG_ARM_DT_BL_CPUFREQ) += arm_big_little_dt.o
>>
>> -obj-$(CONFIG_ARCH_DAVINCI_DA850) += davinci-cpufreq.o
>> +obj-$(CONFIG_ARCH_DAVINCI) += davinci-cpufreq.o
>> obj-$(CONFIG_UX500_SOC_DB8500) += dbx500-cpufreq.o
>> obj-$(CONFIG_ARM_EXYNOS_CPUFREQ) += exynos-cpufreq.o
>> obj-$(CONFIG_ARM_EXYNOS4210_CPUFREQ) += exynos4210-cpufreq.o
>
> It took one year and 5 kernel releases to catch this again?
>
For a long time I was been working on DA850 itself, so couldn’t
notice it :(.
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Thanks!
Regards,
--Prabhakar Lad
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-08 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-08 15:25 [PATCH] cpufreq: Makefile: fix compilation for davinci platform Lad, Prabhakar
2014-07-08 15:29 ` Viresh Kumar
2014-07-08 15:32 ` Prabhakar Lad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®