From: Havard Skinnemoen <hskinnemoen@google.com>
To: Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, Ewout van Bekkum <ewout@google.com>,
Havard Skinnemoen <hskinnemoen@google.com>
Subject: [PATCH 3/6] x86-mce: Clear CMCI enable on all claimed CMCI banks before reboot.
Date: Wed, 9 Jul 2014 10:09:23 -0700 [thread overview]
Message-ID: <1404925766-32253-4-git-send-email-hskinnemoen@google.com> (raw)
In-Reply-To: <1404925766-32253-1-git-send-email-hskinnemoen@google.com>
From: Ewout van Bekkum <ewout@google.com>
The existing CMCI code did not call cmci_clear() on each CPU upon
reboot. This meant that a kexec would leave all the CMCI banks
unclaimable and with polling disabled as the cmci_discover() method
relies on the CMCI enable bit for each bank to determine if they can be
claimed.
Signed-off-by: Ewout van Bekkum <ewout@google.com>
Signed-off-by: Havard Skinnemoen <hskinnemoen@google.com>
---
arch/x86/kernel/cpu/mcheck/mce_intel.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/arch/x86/kernel/cpu/mcheck/mce_intel.c b/arch/x86/kernel/cpu/mcheck/mce_intel.c
index d015daf..36a1948 100644
--- a/arch/x86/kernel/cpu/mcheck/mce_intel.c
+++ b/arch/x86/kernel/cpu/mcheck/mce_intel.c
@@ -14,6 +14,8 @@
#include <asm/processor.h>
#include <asm/msr.h>
#include <asm/mce.h>
+#include <linux/reboot.h>
+#include <linux/atomic.h>
#include "mce-internal.h"
@@ -388,6 +390,31 @@ void cmci_disable_bank(int bank)
spin_unlock_irqrestore(&cmci_discover_lock, flags);
}
+/*
+ * Fully disable CMCI on this CPU in case of shutdown.
+ */
+static void cmci_disable(void *dummy)
+{
+ cmci_clear();
+}
+
+static int cmci_reboot_event(struct notifier_block *this,
+ unsigned long event, void *ptr)
+{
+ /*
+ * Disable CMCI on this CPU for all banks it owns so CPUs after the
+ * reboot can reclaim the banks through rediscovery.
+ */
+ on_each_cpu(cmci_disable, NULL, 1);
+ return NOTIFY_OK;
+}
+
+static struct notifier_block cmci_reboot_notifier = {
+ .notifier_call = cmci_reboot_event,
+};
+
+static bool reboot_notifier_registered;
+
static void intel_init_cmci(void)
{
int banks;
@@ -395,6 +422,9 @@ static void intel_init_cmci(void)
if (!cmci_supported(&banks))
return;
+ if (!xchg(&reboot_notifier_registered, true))
+ register_reboot_notifier(&cmci_reboot_notifier);
+
mce_threshold_vector = intel_threshold_interrupt;
cmci_discover(banks);
/*
--
2.0.0.526.g5318336
next prev parent reply other threads:[~2014-07-09 17:09 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 17:09 [PATCH 0/6] x86 mce fixes Havard Skinnemoen
2014-07-09 17:09 ` [PATCH 1/6] x86-mce: Modify CMCI poll interval to adjust for small check_interval values Havard Skinnemoen
2014-07-09 19:17 ` Borislav Petkov
2014-07-09 21:24 ` Havard Skinnemoen
2014-07-10 9:01 ` Chen, Gong
2014-07-10 17:16 ` Havard Skinnemoen
2014-07-11 2:12 ` Chen, Gong
2014-07-10 11:42 ` Borislav Petkov
2014-07-10 17:51 ` Havard Skinnemoen
2014-07-10 18:55 ` Tony Luck
2014-07-10 22:45 ` Havard Skinnemoen
2014-07-11 15:35 ` Borislav Petkov
2014-07-11 18:56 ` Havard Skinnemoen
2014-07-11 20:10 ` Borislav Petkov
2014-07-11 20:39 ` Havard Skinnemoen
2014-07-14 14:57 ` Borislav Petkov
2014-07-11 20:22 ` Borislav Petkov
2014-07-12 0:10 ` Havard Skinnemoen
2014-07-14 15:14 ` Borislav Petkov
2014-07-11 20:36 ` Borislav Petkov
2014-07-11 21:05 ` Havard Skinnemoen
2014-07-09 17:09 ` [PATCH 2/6] x86-mce: Modify CMCI storm exit to reenable instead of rediscover banks Havard Skinnemoen
2014-07-09 20:20 ` Luck, Tony
2014-07-09 21:34 ` Havard Skinnemoen
2014-07-10 15:51 ` Borislav Petkov
2014-07-10 18:32 ` Havard Skinnemoen
2014-07-09 17:09 ` Havard Skinnemoen [this message]
2014-07-09 20:36 ` [PATCH 3/6] x86-mce: Clear CMCI enable on all claimed CMCI banks before reboot Luck, Tony
2014-07-09 21:40 ` Havard Skinnemoen
2014-07-10 16:24 ` Borislav Petkov
2014-07-10 16:33 ` Tony Luck
2014-07-10 17:56 ` Havard Skinnemoen
2014-07-10 18:27 ` Tony Luck
2014-07-10 18:30 ` Borislav Petkov
2014-07-09 17:09 ` [PATCH 4/6] x86-mce: Add spinlocks to prevent duplicated MCP and CMCI reports Havard Skinnemoen
2014-07-09 20:35 ` Andi Kleen
2014-07-09 21:51 ` Havard Skinnemoen
2014-07-09 23:32 ` Luck, Tony
2014-07-10 8:16 ` Borislav Petkov
2014-07-09 20:47 ` Luck, Tony
2014-07-09 21:56 ` Havard Skinnemoen
2014-07-10 16:41 ` Borislav Petkov
2014-07-10 18:03 ` Havard Skinnemoen
2014-07-10 18:44 ` Borislav Petkov
2014-07-10 18:57 ` Tony Luck
2014-07-10 19:12 ` Borislav Petkov
2014-07-11 9:24 ` Borislav Petkov
2014-07-11 19:06 ` Tony Luck
2014-07-11 19:52 ` Borislav Petkov
2014-07-11 21:15 ` Havard Skinnemoen
2014-07-17 10:50 ` Borislav Petkov
2014-07-18 21:23 ` Tony Luck
2014-07-18 21:31 ` Borislav Petkov
2014-07-09 17:09 ` [PATCH 5/6] x86-mce: check if no_way_out applies before deciding not to clear MCE banks Havard Skinnemoen
2014-07-09 21:00 ` Luck, Tony
2014-07-09 23:00 ` Havard Skinnemoen
2014-07-09 23:27 ` Luck, Tony
2014-07-10 16:49 ` Borislav Petkov
2014-07-09 17:09 ` [PATCH 6/6] x86-mce: ensure the MCP timer is not already set in the mce_timer_fn Havard Skinnemoen
2014-07-09 21:04 ` Luck, Tony
2014-07-09 23:01 ` Havard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404925766-32253-4-git-send-email-hskinnemoen@google.com \
--to=hskinnemoen@google.com \
--cc=bp@alien8.de \
--cc=ewout@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®