From: Tom Gundersen <teg@jklm.no>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>,
David Herrmann <dh.herrmann@gmail.com>,
Kay Sievers <kay@vrfy.org>, Tom Gundersen <teg@jklm.no>,
Roland Dreier <roland@kernel.org>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Erez Shitrit <erezsh@mellanox.com>,
Michal Schmidt <mschmidt@redhat.com>,
Jim Foraker <foraker1@llnl.gov>,
linux-rdma@vger.kernel.org
Subject: [PATCH v7 26/33] net: ipoib - set name assign type
Date: Thu, 10 Jul 2014 10:17:31 +0200 [thread overview]
Message-ID: <1404980258-30853-27-git-send-email-teg@jklm.no> (raw)
In-Reply-To: <1404980258-30853-1-git-send-email-teg@jklm.no>
When naming a device based on a combination of the parent device, and
the upsr-supplied key, inherit the name assign type from the parent.
Signed-off-by: Tom Gundersen <teg@jklm.no>
Cc: Roland Dreier <roland@kernel.org>
Cc: Sean Hefty <sean.hefty@intel.com>
Cc: Hal Rosenstock <hal.rosenstock@gmail.com>
Cc: Erez Shitrit <erezsh@mellanox.com>
Cc: Michal Schmidt <mschmidt@redhat.com>
Cc: Jim Foraker <foraker1@llnl.gov>
Cc: linux-rdma@vger.kernel.org
---
drivers/infiniband/ulp/ipoib/ipoib.h | 2 +-
drivers/infiniband/ulp/ipoib/ipoib_main.c | 12 +++++++-----
drivers/infiniband/ulp/ipoib/ipoib_vlan.c | 2 +-
3 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/infiniband/ulp/ipoib/ipoib.h b/drivers/infiniband/ulp/ipoib/ipoib.h
index c639f90..2654288 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib.h
+++ b/drivers/infiniband/ulp/ipoib/ipoib.h
@@ -464,7 +464,7 @@ void ipoib_reap_ah(struct work_struct *work);
void ipoib_mark_paths_invalid(struct net_device *dev);
void ipoib_flush_paths(struct net_device *dev);
-struct ipoib_dev_priv *ipoib_intf_alloc(const char *format);
+struct ipoib_dev_priv *ipoib_intf_alloc(const char *format, unsigned char name_assign_type);
int ipoib_ib_dev_init(struct net_device *dev, struct ib_device *ca, int port);
void ipoib_ib_dev_flush_light(struct work_struct *work);
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
index 4e675f4..b1d58ef 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -1390,12 +1390,13 @@ void ipoib_setup(struct net_device *dev)
INIT_DELAYED_WORK(&priv->neigh_reap_task, ipoib_reap_neigh);
}
-struct ipoib_dev_priv *ipoib_intf_alloc(const char *name)
+struct ipoib_dev_priv *ipoib_intf_alloc(const char *name,
+ unsigned char name_assign_type)
{
struct net_device *dev;
- dev = alloc_netdev((int)sizeof(struct ipoib_dev_priv), name,
- NET_NAME_UNKNOWN, ipoib_setup);
+ dev = alloc_netdev((int) sizeof (struct ipoib_dev_priv), name,
+ name_assign_type, ipoib_setup);
if (!dev)
return NULL;
@@ -1535,13 +1536,14 @@ int ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca)
}
static struct net_device *ipoib_add_port(const char *format,
+ unsigned char name_assign_type,
struct ib_device *hca, u8 port)
{
struct ipoib_dev_priv *priv;
struct ib_port_attr attr;
int result = -ENOMEM;
- priv = ipoib_intf_alloc(format);
+ priv = ipoib_intf_alloc(format, name_assign_type);
if (!priv)
goto alloc_mem_failed;
@@ -1676,7 +1678,7 @@ static void ipoib_add_one(struct ib_device *device)
for (p = s; p <= e; ++p) {
if (rdma_port_get_link_layer(device, p) != IB_LINK_LAYER_INFINIBAND)
continue;
- dev = ipoib_add_port("ib%d", device, p);
+ dev = ipoib_add_port("ib%d", NET_NAME_ENUM, device, p);
if (!IS_ERR(dev)) {
priv = netdev_priv(dev);
list_add_tail(&priv->list, dev_list);
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_vlan.c b/drivers/infiniband/ulp/ipoib/ipoib_vlan.c
index 9fad7b5..88558d3 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_vlan.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_vlan.c
@@ -133,7 +133,7 @@ int ipoib_vlan_add(struct net_device *pdev, unsigned short pkey)
snprintf(intf_name, sizeof intf_name, "%s.%04x",
ppriv->dev->name, pkey);
- priv = ipoib_intf_alloc(intf_name);
+ priv = ipoib_intf_alloc(intf_name, ppriv->dev->name_assign_type);
if (!priv)
return -ENOMEM;
--
1.9.3
next prev parent reply other threads:[~2014-07-10 8:22 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 8:17 [PATCH v7 00/33] Provide netdev naming-policy via sysfs Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 01/33] net: add name_assign_type netdev attribute Tom Gundersen
2014-07-10 15:53 ` Nicolas Dichtel
2014-07-10 20:00 ` Tom Gundersen
2014-07-10 19:58 ` Arend van Spriel
2014-07-10 20:01 ` Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 02/33] net: set name assign type for renamed devices Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 03/33] net: set name_assign_type in alloc_netdev() Tom Gundersen
2014-07-10 9:16 ` Bjørn Mork
2014-07-10 10:21 ` Tom Gundersen
2014-07-10 11:29 ` Bjørn Mork
2014-07-10 13:02 ` Tom Gundersen
2014-07-10 13:27 ` Bjørn Mork
2014-07-10 8:17 ` [PATCH v7 04/33] net: set name assign type for names assigned using a static template Tom Gundersen
2014-07-10 8:52 ` Marc Kleine-Budde
2014-07-10 8:17 ` [PATCH v7 05/33] net: set name assign type for names assigned using a static string Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 06/33] net: set name assign type for names passed directly from userspace Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 07/33] net: rtnetlink - make create_link take name_assign_type Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 08/33] net: nl80211 - make rdev_add_virtual_intf " Tom Gundersen
2014-07-21 9:40 ` Johannes Berg
2014-07-21 17:03 ` Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 09/33] net: nl802154 - make add_iface take name assign type Tom Gundersen
2014-07-10 10:52 ` Alexander Aring
2014-07-10 8:17 ` [PATCH v7 10/33] net: dummy - set " Tom Gundersen
2014-07-10 9:31 ` Bjørn Mork
2014-07-10 10:12 ` Tom Gundersen
2014-07-10 10:26 ` David Herrmann
2014-07-10 10:33 ` Tom Gundersen
2014-07-10 11:44 ` Bjørn Mork
2014-07-10 12:18 ` Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 11/33] net: af_netrom " Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 12/33] net: af_rose " Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 13/33] net: mrt " Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 14/33] net: caif_serial " Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 15/33] net: xen-netback " Tom Gundersen
2014-07-10 8:25 ` Varka Bhadram
2014-07-10 9:01 ` Ian Campbell
2014-07-10 10:46 ` Tom Gundersen
2014-07-10 12:13 ` Ian Campbell
2014-07-10 8:17 ` [PATCH v7 16/33] net: gdm_lte " Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 17/33] net: airo " Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 18/33] net: arcdev - label alloc_arcdev names Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 19/33] net: isdn - set name assign type Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 20/33] net: irlan " Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 21/33] net: batman-adv " Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 22/33] net: hamradio " Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 23/33] net: openvswitch " Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 24/33] net: vlan " Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 25/33] net: infiniband - steal ifname label Tom Gundersen
2014-07-10 8:17 ` Tom Gundersen [this message]
2014-07-10 8:17 ` [PATCH v7 27/33] net: tile - set name assign type Tom Gundersen
2014-07-16 17:49 ` Chris Metcalf
2014-07-10 8:17 ` [PATCH v7 28/33] net: dsa " Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 29/33] net: brcmfmac " Tom Gundersen
2014-07-10 20:08 ` Arend van Spriel
2014-07-10 20:24 ` Tom Gundersen
2014-07-11 7:45 ` Arend van Spriel
2014-07-15 19:39 ` John W. Linville
2014-07-15 19:57 ` Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 30/33] net: ppp " Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 31/33] net: slcan " Tom Gundersen
2014-07-10 8:51 ` Marc Kleine-Budde
2014-07-10 8:17 ` [PATCH v7 32/33] net: x25_asy " Tom Gundersen
2014-07-10 8:17 ` [PATCH v7 33/33] net: slip " Tom Gundersen
2014-07-10 8:43 ` [PATCH v7 00/33] Provide netdev naming-policy via sysfs David Miller
2014-07-10 9:19 ` Tom Gundersen
2014-07-10 19:11 ` Tom Gundersen
2014-07-10 19:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1404980258-30853-27-git-send-email-teg@jklm.no \
--to=teg@jklm.no \
--cc=davem@davemloft.net \
--cc=dh.herrmann@gmail.com \
--cc=erezsh@mellanox.com \
--cc=foraker1@llnl.gov \
--cc=hal.rosenstock@gmail.com \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®