mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tom Gundersen <teg@jklm.no>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>,
	David Herrmann <dh.herrmann@gmail.com>,
	Kay Sievers <kay@vrfy.org>, Tom Gundersen <teg@jklm.no>
Subject: [PATCH v7 02/33] net: set name assign type for renamed devices
Date: Thu, 10 Jul 2014 10:17:07 +0200	[thread overview]
Message-ID: <1404980258-30853-3-git-send-email-teg@jklm.no> (raw)
In-Reply-To: <1404980258-30853-1-git-send-email-teg@jklm.no>

Based on a patch from David Herrmann.

This is the only place devices can be renamed.

Signed-off-by: Tom Gundersen <teg@jklm.no>
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
---
 net/core/dev.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/net/core/dev.c b/net/core/dev.c
index 30eedf6..7765ec5 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1083,6 +1083,7 @@ static int dev_get_valid_name(struct net *net,
 int dev_change_name(struct net_device *dev, const char *newname)
 {
 	char oldname[IFNAMSIZ];
+	unsigned char old_assign_type;
 	int err = 0;
 	int ret;
 	struct net *net;
@@ -1109,10 +1110,14 @@ int dev_change_name(struct net_device *dev, const char *newname)
 		return err;
 	}
 
+	old_assign_type = dev->name_assign_type;
+	dev->name_assign_type = NET_NAME_RENAMED;
+
 rollback:
 	ret = device_rename(&dev->dev, dev->name);
 	if (ret) {
 		memcpy(dev->name, oldname, IFNAMSIZ);
+		dev->name_assign_type = old_assign_type;
 		write_seqcount_end(&devnet_rename_seq);
 		return ret;
 	}
@@ -1141,6 +1146,8 @@ rollback:
 			write_seqcount_begin(&devnet_rename_seq);
 			memcpy(dev->name, oldname, IFNAMSIZ);
 			memcpy(oldname, newname, IFNAMSIZ);
+			dev->name_assign_type = old_assign_type;
+			old_assign_type = NET_NAME_RENAMED;
 			goto rollback;
 		} else {
 			pr_err("%s: name change rollback failed: %d\n",
-- 
1.9.3


  parent reply	other threads:[~2014-07-10  8:18 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-10  8:17 [PATCH v7 00/33] Provide netdev naming-policy via sysfs Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 01/33] net: add name_assign_type netdev attribute Tom Gundersen
2014-07-10 15:53   ` Nicolas Dichtel
2014-07-10 20:00     ` Tom Gundersen
2014-07-10 19:58   ` Arend van Spriel
2014-07-10 20:01     ` Tom Gundersen
2014-07-10  8:17 ` Tom Gundersen [this message]
2014-07-10  8:17 ` [PATCH v7 03/33] net: set name_assign_type in alloc_netdev() Tom Gundersen
2014-07-10  9:16   ` Bjørn Mork
2014-07-10 10:21     ` Tom Gundersen
2014-07-10 11:29       ` Bjørn Mork
2014-07-10 13:02         ` Tom Gundersen
2014-07-10 13:27           ` Bjørn Mork
2014-07-10  8:17 ` [PATCH v7 04/33] net: set name assign type for names assigned using a static template Tom Gundersen
2014-07-10  8:52   ` Marc Kleine-Budde
2014-07-10  8:17 ` [PATCH v7 05/33] net: set name assign type for names assigned using a static string Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 06/33] net: set name assign type for names passed directly from userspace Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 07/33] net: rtnetlink - make create_link take name_assign_type Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 08/33] net: nl80211 - make rdev_add_virtual_intf " Tom Gundersen
2014-07-21  9:40   ` Johannes Berg
2014-07-21 17:03     ` Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 09/33] net: nl802154 - make add_iface take name assign type Tom Gundersen
2014-07-10 10:52   ` Alexander Aring
2014-07-10  8:17 ` [PATCH v7 10/33] net: dummy - set " Tom Gundersen
2014-07-10  9:31   ` Bjørn Mork
2014-07-10 10:12     ` Tom Gundersen
2014-07-10 10:26       ` David Herrmann
2014-07-10 10:33         ` Tom Gundersen
2014-07-10 11:44       ` Bjørn Mork
2014-07-10 12:18         ` Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 11/33] net: af_netrom " Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 12/33] net: af_rose " Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 13/33] net: mrt " Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 14/33] net: caif_serial " Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 15/33] net: xen-netback " Tom Gundersen
2014-07-10  8:25   ` Varka Bhadram
2014-07-10  9:01   ` Ian Campbell
2014-07-10 10:46     ` Tom Gundersen
2014-07-10 12:13       ` Ian Campbell
2014-07-10  8:17 ` [PATCH v7 16/33] net: gdm_lte " Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 17/33] net: airo " Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 18/33] net: arcdev - label alloc_arcdev names Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 19/33] net: isdn - set name assign type Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 20/33] net: irlan " Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 21/33] net: batman-adv " Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 22/33] net: hamradio " Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 23/33] net: openvswitch " Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 24/33] net: vlan " Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 25/33] net: infiniband - steal ifname label Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 26/33] net: ipoib - set name assign type Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 27/33] net: tile " Tom Gundersen
2014-07-16 17:49   ` Chris Metcalf
2014-07-10  8:17 ` [PATCH v7 28/33] net: dsa " Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 29/33] net: brcmfmac " Tom Gundersen
2014-07-10 20:08   ` Arend van Spriel
2014-07-10 20:24     ` Tom Gundersen
2014-07-11  7:45       ` Arend van Spriel
2014-07-15 19:39   ` John W. Linville
2014-07-15 19:57     ` Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 30/33] net: ppp " Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 31/33] net: slcan " Tom Gundersen
2014-07-10  8:51   ` Marc Kleine-Budde
2014-07-10  8:17 ` [PATCH v7 32/33] net: x25_asy " Tom Gundersen
2014-07-10  8:17 ` [PATCH v7 33/33] net: slip " Tom Gundersen
2014-07-10  8:43 ` [PATCH v7 00/33] Provide netdev naming-policy via sysfs David Miller
2014-07-10  9:19   ` Tom Gundersen
2014-07-10 19:11     ` Tom Gundersen
2014-07-10 19:19     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404980258-30853-3-git-send-email-teg@jklm.no \
    --to=teg@jklm.no \
    --cc=davem@davemloft.net \
    --cc=dh.herrmann@gmail.com \
    --cc=kay@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®