mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicholas Krause <xerofoify@gmail.com>
To: rth@twiddle.net
Cc: ink@jurassic.park.msu.ru, mattst88@gmail.com,
	linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] alpha: checkpatch errors in mkbb for if statements
Date: Wed, 16 Jul 2014 00:14:00 -0400	[thread overview]
Message-ID: <1405484042-6879-2-git-send-email-xerofoify@gmail.com> (raw)
In-Reply-To: <1405484042-6879-1-git-send-email-xerofoify@gmail.com>

This patch fixes all errors related to no space between if and parthesises
to remove this errors when running checkpatch against this file.
---
 arch/alpha/boot/tools/mkbb.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/alpha/boot/tools/mkbb.c b/arch/alpha/boot/tools/mkbb.c
index 6f1b957..214b6c7 100644
--- a/arch/alpha/boot/tools/mkbb.c
+++ b/arch/alpha/boot/tools/mkbb.c
@@ -91,21 +91,21 @@ int main(int argc, char ** argv)
 	int			nread;
 
     /* Make sure of the arg count */
-	if(argc != 3) {
+	if (argc != 3) {
 	fprintf(stderr, "Usage: %s device lxboot\n", argv[0]);
 	exit(0);
 	}
 
     /* First, open the device and make sure it's accessible */
 	dev = open(argv[1], O_RDWR);
-	if(dev < 0) {
+	if (dev < 0) {
 	perror(argv[1]);
 	exit(0);
 	}
 
     /* Now open the lxboot and make sure it's reasonable */
 	fd = open(argv[2], O_RDONLY);
-	if(fd < 0) {
+	if (fd < 0) {
 	perror(argv[2]);
 	close(dev);
 	exit(0);
@@ -113,7 +113,7 @@ int main(int argc, char ** argv)
 
     /* Read in the lxboot */
 	nread = read(fd, &bootloader_image, sizeof(bootblock));
-	if(nread != sizeof(bootblock)) {
+	if (nread != sizeof(bootblock)) {
 	perror("lxboot read");
 	fprintf(stderr, "expected %zd, got %d\n", sizeof(bootblock), nread);
 	exit(0);
@@ -121,7 +121,7 @@ int main(int argc, char ** argv)
 
     /* Read in the bootblock from disk. */
 	nread = read(dev, &bootblock_from_disk, sizeof(bootblock));
-	if(nread != sizeof(bootblock)) {
+	if (nread != sizeof(bootblock)) {
 	perror("bootblock read");
 	fprintf(stderr, "expected %zd, got %d\n", sizeof(bootblock), nread);
 	exit(0);
@@ -132,14 +132,14 @@ int main(int argc, char ** argv)
 
     /* Calculate the bootblock checksum */
 	bootloader_image.bootblock_checksum = 0;
-	for(i = 0; i < 63; i++) {
+	for (i = 0; i < 63; i++) {
 	bootloader_image.bootblock_checksum +=
 			bootloader_image.bootblock_quadwords[i];
 	}
 
     /* Write the whole thing out! */
 	lseek(dev, 0L, SEEK_SET);
-	if(write(dev, &bootloader_image, sizeof(bootblock)) != sizeof(bootblock)) {
+	if (write(dev, &bootloader_image, sizeof(bootblock)) != sizeof(bootblock)) {
 	perror("bootblock write");
 	exit(0);
 	}
-- 
1.9.1


  reply	other threads:[~2014-07-16  4:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16  4:13 [PATCH 1/4] alpha: Converse all space errors into tabs in mkbb.c Nicholas Krause
2014-07-16  4:14 ` Nicholas Krause [this message]
2014-07-16  4:14 ` [PATCH 3/4] alpha: Indent if Statements properly Nicholas Krause
2014-07-16  4:14 ` [PATCH 4/4] alpha: Remove checkpatch error in mkk.b Nicholas Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405484042-6879-2-git-send-email-xerofoify@gmail.com \
    --to=xerofoify@gmail.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®