From: Michael Ellerman <mpe@ellerman.id.au>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@redhat.com, linux-kernel@vger.kernel.org,
namhyung@kernel.org, acme@infradead.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 05/11] perf, tools: Add support for reading JSON event files
Date: Fri, 18 Jul 2014 15:29:42 +1000 [thread overview]
Message-ID: <1405661382.17297.3.camel@concordia> (raw)
In-Reply-To: <1405123165-22666-6-git-send-email-andi@firstfloor.org>
On Fri, 2014-07-11 at 16:59 -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Add a parser for Intel style JSON event files. This allows
> to use an Intel event list directly with perf. The Intel
> event lists can be quite large and are too big to store
> in unswappable kernel memory.
...
> diff --git a/tools/perf/util/jevents.c b/tools/perf/util/jevents.c
> new file mode 100644
> index 0000000..a23f57f
> --- /dev/null
> +++ b/tools/perf/util/jevents.c
> @@ -0,0 +1,246 @@
...
> +
> +static void fixname(char *s)
> +{
> + for (; *s; s++)
> + *s = tolower(*s);
> +}
On powerpc our event names are always uppercase, it would be nice if the perf
list output honoured that.
Can we instead just honour whatever case is in the input JSON ?
It looks like the event lookup is already case insensitive.
cheers
next prev parent reply other threads:[~2014-07-18 5:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 23:59 perf: Add support for full Intel event lists v7 Andi Kleen
2014-07-11 23:59 ` [PATCH 01/11] perf, tools: Add jsmn `jasmine' JSON parser Andi Kleen
2014-07-11 23:59 ` [PATCH 02/11] perf, tools: Add support for text descriptions of events and alias add Andi Kleen
2014-07-11 23:59 ` [PATCH 03/11] perf, tools, list: Update perf list to output descriptions Andi Kleen
2014-07-11 23:59 ` [PATCH 04/11] perf, tools: Allow events with dot Andi Kleen
2014-07-11 23:59 ` [PATCH 05/11] perf, tools: Add support for reading JSON event files Andi Kleen
2014-07-18 5:29 ` Michael Ellerman [this message]
2014-07-18 17:40 ` Andi Kleen
2014-07-11 23:59 ` [PATCH 06/11] perf, tools: Automatically look for event file name for cpu Andi Kleen
2014-07-18 6:43 ` Michael Ellerman
2014-07-11 23:59 ` [PATCH 07/11] perf, tools: Add perf download to download event files Andi Kleen
2014-07-18 6:28 ` Michael Ellerman
2014-07-11 23:59 ` [PATCH 08/11] perf, tools: Query terminal width and use in perf list Andi Kleen
2014-07-11 23:59 ` [PATCH 09/11] perf, tools: Add a new pmu interface to iterate over all events Andi Kleen
2014-07-11 23:59 ` [PATCH 10/11] perf, tools, test: Add test case for alias and JSON parsing Andi Kleen
2014-07-12 23:10 ` Jiri Olsa
2014-07-12 23:49 ` Andi Kleen
2014-07-13 20:09 ` Jiri Olsa
2014-07-14 1:44 ` Andi Kleen
2014-07-11 23:59 ` [PATCH 11/11] perf, tools: Add a --no-desc flag to perf list Andi Kleen
2014-07-18 8:57 ` perf: Add support for full Intel event lists v7 Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405661382.17297.3.camel@concordia \
--to=mpe@ellerman.id.au \
--cc=acme@infradead.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome