mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Andi Kleen <andi@firstfloor.org>
Cc: jolsa@redhat.com, linux-kernel@vger.kernel.org,
	namhyung@kernel.org, acme@infradead.org,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 07/11] perf, tools: Add perf download to download event files
Date: Fri, 18 Jul 2014 16:28:40 +1000	[thread overview]
Message-ID: <1405664920.17297.4.camel@concordia> (raw)
In-Reply-To: <1405123165-22666-8-git-send-email-andi@firstfloor.org>

On Fri, 2014-07-11 at 16:59 -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> Add a downloader to automatically download the right
> files from a download site.
...
> diff --git a/tools/perf/Documentation/perf-download.txt b/tools/perf/Documentation/perf-download.txt
> new file mode 100644
> index 0000000..9e5b28e
> --- /dev/null
> +++ b/tools/perf/Documentation/perf-download.txt
> @@ -0,0 +1,31 @@
> +perf-download(1)
> +===============
> +
> +NAME
> +----
> +perf-download - Download event files for current CPU.
> +
> +SYNOPSIS
> +--------
> +[verse]
> +'perf download' [vendor-family-model]

Can you make that arch agnostic? eg:

> +'perf download' [cpu-identifier]

> diff --git a/tools/perf/perf-download.sh b/tools/perf/perf-download.sh
> new file mode 100755
> index 0000000..269dc96
> --- /dev/null
> +++ b/tools/perf/perf-download.sh
> @@ -0,0 +1,57 @@
> +#!/bin/bash
> +# download event files for current cpu for perf
> +
> +CURLOPT=${CURLOPT:- --max-time 5 -#}
> +
> +set -e
> +
> +if ! type curl > /dev/null ; then
> +	echo "please install curl"
> +	exit 1
> +fi
> +
> +if [ "$1" == "" ] ; then
> +	S=$(awk '
> +/^vendor/     		{ V=$3 }
> +/^model/ && $2 == ":" 	{ M=$3 }
> +/^cpu family/ 		{ F = $4 }
> +END	      		{ printf("%s-%s-%X", V, F, M) }' /proc/cpuinfo)
> +else
> +	S="$1"
> +fi
> +V=$(echo $S  | ( IFS=- read v f m ; echo $v) )

This obviously needs a bit of work to support other arches. I'm thinking we use
uname -m to do a top level switch? eg:

  ARCH=$(uname -m | sed -e s/i.86/i386/ -e s/ppc.*/powerpc/)
  
  if [ "$ARCH" == "x86_64" ] || [ "$ARCH" == "i386" ]; then
          S=$(awk '/^vendor/              { V=$3 }
                   /^model/ && $2 == ":"  { M=$3 }
                   /^cpu family/          { F = $4 }
                   END                    { printf("%s-%s-%X", V, F, M) }' /proc/cpuinfo)
  elif [ "$ARCH" == "powerpc" ]; then
          ...
  fi

> +case "$V" in
> +GenuineIntel)
> +	echo "Downloading models file"
> +	URLBASE=${URLBASE:-https://download.01.org/perfmon}
> +	MAPFILE=${MAPFILE:-mapfile.csv}
> +	echo "Downloading readme.txt"
> +	curl $CURLOPT $URLBASE/readme.txt -o readme.txt
> +	;;
> +
> +# Add more CPU vendors here
> +
> +*)
> +	echo "Unsupported CPU vendor $V"
> +	exit 1
> +	;;
> +esac
> +
> +curl $CURLOPT $URLBASE/$MAPFILE -o $MAPFILE
> +
> +echo "Downloading events file"
> +awk -v urlbase=$URLBASE -v cpu="$S" -F, \
> +	'$1 == cpu && $4 == "core" { print "url = \"" urlbase $3 "\""; exit 0 }' \
> +	$MAPFILE > url$$
> +if [ -s url$$ ] ; then
> +	curl $CURLOPT -K url$$ -o $S-core.json
> +else
> +	echo "CPU $S not found"
> +fi

I'm not 100% sure, but I think we will want to use our PVR register as the
lookup key. That's just a hex value, with major and minor versions.

To make that work I think we will want a loop in the map lookup to handle
chopping off the low bits.

So for example it would check the MAPFILE for:
  003e0301
  003e030
  003e03
  003e0

etc.

So we might need another arch specific chunk in there.

cheers



  reply	other threads:[~2014-07-18  6:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11 23:59 perf: Add support for full Intel event lists v7 Andi Kleen
2014-07-11 23:59 ` [PATCH 01/11] perf, tools: Add jsmn `jasmine' JSON parser Andi Kleen
2014-07-11 23:59 ` [PATCH 02/11] perf, tools: Add support for text descriptions of events and alias add Andi Kleen
2014-07-11 23:59 ` [PATCH 03/11] perf, tools, list: Update perf list to output descriptions Andi Kleen
2014-07-11 23:59 ` [PATCH 04/11] perf, tools: Allow events with dot Andi Kleen
2014-07-11 23:59 ` [PATCH 05/11] perf, tools: Add support for reading JSON event files Andi Kleen
2014-07-18  5:29   ` Michael Ellerman
2014-07-18 17:40     ` Andi Kleen
2014-07-11 23:59 ` [PATCH 06/11] perf, tools: Automatically look for event file name for cpu Andi Kleen
2014-07-18  6:43   ` Michael Ellerman
2014-07-11 23:59 ` [PATCH 07/11] perf, tools: Add perf download to download event files Andi Kleen
2014-07-18  6:28   ` Michael Ellerman [this message]
2014-07-11 23:59 ` [PATCH 08/11] perf, tools: Query terminal width and use in perf list Andi Kleen
2014-07-11 23:59 ` [PATCH 09/11] perf, tools: Add a new pmu interface to iterate over all events Andi Kleen
2014-07-11 23:59 ` [PATCH 10/11] perf, tools, test: Add test case for alias and JSON parsing Andi Kleen
2014-07-12 23:10   ` Jiri Olsa
2014-07-12 23:49     ` Andi Kleen
2014-07-13 20:09       ` Jiri Olsa
2014-07-14  1:44         ` Andi Kleen
2014-07-11 23:59 ` [PATCH 11/11] perf, tools: Add a --no-desc flag to perf list Andi Kleen
2014-07-18  8:57 ` perf: Add support for full Intel event lists v7 Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405664920.17297.4.camel@concordia \
    --to=mpe@ellerman.id.au \
    --cc=acme@infradead.org \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®