From: James Bottomley <jbottomley@parallels.com>
To: "hch@infradead.org" <hch@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"apw@canonical.com" <apw@canonical.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"kys@microsoft.com" <kys@microsoft.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"ohering@suse.com" <ohering@suse.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jasowang@redhat.com" <jasowang@redhat.com>
Subject: Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout
Date: Fri, 18 Jul 2014 17:03:47 +0000 [thread overview]
Message-ID: <1405703026.30262.4.camel@dabdike.int.hansenpartnership.com> (raw)
In-Reply-To: <20140718170030.GA31769@infradead.org>
On Fri, 2014-07-18 at 10:00 -0700, Christoph Hellwig wrote:
> On Wed, Jun 04, 2014 at 09:33:43AM -0700, K. Y. Srinivasan wrote:
> > Commit ID: 7e660100d85af860e7ad763202fff717adcdaacd added code to derive the
> > FLUSH_TIMEOUT from the basic I/O timeout. However, this patch did not use the
> > basic I/O timeout of the device. Fix this bug.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
>
> Looks good to me,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> (it will need some changes to apply to my tree, but I'm happy to do that
> if I can get another review).
>
> James, does this look fine to you?
Yes:
Reviewed-by: James Bottomley <JBottomley@Parallels.com>
James
prev parent reply other threads:[~2014-07-18 17:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 16:33 K. Y. Srinivasan
2014-06-04 17:02 ` James Bottomley
2014-06-04 17:15 ` KY Srinivasan
2014-06-06 1:32 ` Mike Christie
2014-06-06 2:53 ` KY Srinivasan
2014-06-06 17:18 ` Mike Christie
2014-06-06 17:52 ` James Bottomley
2014-06-06 18:22 ` Jens Axboe
2014-06-20 21:36 ` KY Srinivasan
2014-07-17 23:53 ` KY Srinivasan
2014-07-18 0:51 ` Elliott, Robert (Server Storage)
2014-07-18 15:11 ` Christoph Hellwig (hch@infradead.org)
2014-07-18 15:39 ` James Bottomley
2014-07-18 17:17 ` Elliott, Robert (Server Storage)
2014-07-18 17:41 ` James Bottomley
2014-07-18 18:16 ` Douglas Gilbert
2014-07-18 15:10 ` Christoph Hellwig (hch@infradead.org)
2014-07-18 16:44 ` KY Srinivasan
2014-07-18 16:57 ` James Bottomley
2014-07-18 17:01 ` hch
2014-07-18 17:05 ` KY Srinivasan
2014-07-18 17:12 ` hch
2014-07-18 17:15 ` hch
2014-07-18 17:00 ` Christoph Hellwig
2014-07-18 17:03 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405703026.30262.4.camel@dabdike.int.hansenpartnership.com \
--to=jbottomley@parallels.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ohering@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®