* [PATCH v2 1/2] xen/setup: Remove Identity Map Debug Message
@ 2014-07-19 23:51 Matt Rushton
0 siblings, 0 replies; 3+ messages in thread
From: Matt Rushton @ 2014-07-19 23:51 UTC (permalink / raw)
To: konrad.wilk, boris.ostrovsky, david.vrabel
Cc: msw, linux-kernel, xen-devel, Matt Rushton
Removing a debug message for setting the identity map since it becomes
rather noisy after rework of the identity map code.
Signed-off-by: Matthew Rushton <mrushton@amazon.com>
---
arch/x86/xen/p2m.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c
index 9bb3d82..3172692 100644
--- a/arch/x86/xen/p2m.c
+++ b/arch/x86/xen/p2m.c
@@ -841,10 +841,9 @@ unsigned long __init set_phys_range_identity(unsigned long pfn_s,
pfn = ALIGN(pfn, P2M_PER_PAGE);
}
- if (!WARN((pfn - pfn_s) != (pfn_e - pfn_s),
+ WARN((pfn - pfn_s) != (pfn_e - pfn_s),
"Identity mapping failed. We are %ld short of 1-1 mappings!\n",
- (pfn_e - pfn_s) - (pfn - pfn_s)))
- printk(KERN_DEBUG "1-1 mapping on %lx->%lx\n", pfn_s, pfn);
+ (pfn_e - pfn_s) - (pfn - pfn_s));
return pfn - pfn_s;
}
--
1.7.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/2] xen/setup: Remove Identity Map Debug Message
2014-07-20 0:01 Matt Rushton
@ 2014-07-28 13:14 ` David Vrabel
0 siblings, 0 replies; 3+ messages in thread
From: David Vrabel @ 2014-07-28 13:14 UTC (permalink / raw)
To: Matt Rushton, konrad.wilk, boris.ostrovsky
Cc: msw, linux-kernel, xen-devel, Matt Rushton
On 20/07/14 01:01, Matt Rushton wrote:
> Removing a debug message for setting the identity map since it becomes
> rather noisy after rework of the identity map code.
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
David
> --- a/arch/x86/xen/p2m.c
> +++ b/arch/x86/xen/p2m.c
> @@ -841,10 +841,9 @@ unsigned long __init set_phys_range_identity(unsigned long pfn_s,
> pfn = ALIGN(pfn, P2M_PER_PAGE);
> }
>
> - if (!WARN((pfn - pfn_s) != (pfn_e - pfn_s),
> + WARN((pfn - pfn_s) != (pfn_e - pfn_s),
> "Identity mapping failed. We are %ld short of 1-1 mappings!\n",
> - (pfn_e - pfn_s) - (pfn - pfn_s)))
> - printk(KERN_DEBUG "1-1 mapping on %lx->%lx\n", pfn_s, pfn);
> + (pfn_e - pfn_s) - (pfn - pfn_s));
>
> return pfn - pfn_s;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/2] xen/setup: Remove Identity Map Debug Message
@ 2014-07-20 0:01 Matt Rushton
2014-07-28 13:14 ` David Vrabel
0 siblings, 1 reply; 3+ messages in thread
From: Matt Rushton @ 2014-07-20 0:01 UTC (permalink / raw)
To: konrad.wilk, boris.ostrovsky, david.vrabel
Cc: msw, linux-kernel, xen-devel, Matt Rushton
Removing a debug message for setting the identity map since it becomes
rather noisy after rework of the identity map code.
Signed-off-by: Matthew Rushton <mrushton@amazon.com>
---
arch/x86/xen/p2m.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c
index 9bb3d82..3172692 100644
--- a/arch/x86/xen/p2m.c
+++ b/arch/x86/xen/p2m.c
@@ -841,10 +841,9 @@ unsigned long __init set_phys_range_identity(unsigned long pfn_s,
pfn = ALIGN(pfn, P2M_PER_PAGE);
}
- if (!WARN((pfn - pfn_s) != (pfn_e - pfn_s),
+ WARN((pfn - pfn_s) != (pfn_e - pfn_s),
"Identity mapping failed. We are %ld short of 1-1 mappings!\n",
- (pfn_e - pfn_s) - (pfn - pfn_s)))
- printk(KERN_DEBUG "1-1 mapping on %lx->%lx\n", pfn_s, pfn);
+ (pfn_e - pfn_s) - (pfn - pfn_s));
return pfn - pfn_s;
}
--
1.7.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-28 13:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-19 23:51 [PATCH v2 1/2] xen/setup: Remove Identity Map Debug Message Matt Rushton
2014-07-20 0:01 Matt Rushton
2014-07-28 13:14 ` David Vrabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®