* [PATCH 1/1] Staging: comedi: 8255.c Missing a blank line fixed
@ 2014-07-20 0:43 Sam Asadi
2014-07-20 1:11 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Sam Asadi @ 2014-07-20 0:43 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Sam Asadi
A 'Missing a blank line after declarations' issue fixed and also tested
by 'make M=...'. It seems that after 'unsigned long iobase' declaration
a blank line is desperately needed.
Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
---
drivers/staging/comedi/drivers/8255.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/drivers/8255.c b/drivers/staging/comedi/drivers/8255.c
index 46113a3..e591441 100644
--- a/drivers/staging/comedi/drivers/8255.c
+++ b/drivers/staging/comedi/drivers/8255.c
@@ -94,6 +94,7 @@ I/O port base address can be found in the output of 'lspci -v'.
struct subdev_8255_private {
unsigned long iobase;
+
int (*io)(int, int, int, unsigned long);
};
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] Staging: comedi: 8255.c Missing a blank line fixed
2014-07-20 0:43 [PATCH 1/1] Staging: comedi: 8255.c Missing a blank line fixed Sam Asadi
@ 2014-07-20 1:11 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2014-07-20 1:11 UTC (permalink / raw)
To: Sam Asadi; +Cc: gregkh, devel, linux-kernel
On Sun, 2014-07-20 at 03:43 +0300, Sam Asadi wrote:
> A 'Missing a blank line after declarations' issue fixed and also tested
> by 'make M=...'. It seems that after 'unsigned long iobase' declaration
> a blank line is desperately needed.
[]
> diff --git a/drivers/staging/comedi/drivers/8255.c b/drivers/staging/comedi/drivers/8255.c
[]
> @@ -94,6 +94,7 @@ I/O port base address can be found in the output of 'lspci -v'.
>
> struct subdev_8255_private {
> unsigned long iobase;
> +
> int (*io)(int, int, int, unsigned long);
> };
>
You used an old version of checkpatch without a
modification to the "blank line after declarations"
test that supports function pointers.
Use the latest version from --next instead.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-20 1:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-20 0:43 [PATCH 1/1] Staging: comedi: 8255.c Missing a blank line fixed Sam Asadi
2014-07-20 1:11 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®