From: Riccardo Lucchese <riccardo.lucchese@gmail.com>
To: gregkh@linuxfoundation.org
Cc: dan.carpenter@oracle.com, oleg.drokin@intel.com,
josh@joshtriplett.org, dmitry.eremin@intel.com,
john.hammond@intel.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, julia.lawall@lip6.fr,
joe@perches.com, Riccardo Lucchese <riccardo.lucchese@gmail.com>
Subject: [PATCH v3 1/3] staging: lustre: lov: Cleanup lov_check_set() in lov_request.c
Date: Mon, 21 Jul 2014 12:15:55 +0200 [thread overview]
Message-ID: <1405937757-16504-2-git-send-email-riccardo.lucchese@gmail.com> (raw)
In-Reply-To: <1405937757-16504-1-git-send-email-riccardo.lucchese@gmail.com>
Make the code clearer by introducing a local variable and removing the
unnecessary 'if' statement.
Signed-off-by: Riccardo Lucchese <riccardo.lucchese@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
Changes in v3:
- Renamed the local variable 'desc' to 'tgt' to be consistent with
other definitions in the driver.
Changes in v2:
- Improved the commit message:
- changed the subject line to follow the same convention used by
previous commits to the same file.
- rewrote the message body using a more formal language.
- Introduced a local variable to make the code clearer.
- Added Acked-by - Julia.
drivers/staging/lustre/lustre/lov/lov_request.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_request.c b/drivers/staging/lustre/lustre/lov/lov_request.c
index ce830e4..da424de 100644
--- a/drivers/staging/lustre/lustre/lov/lov_request.c
+++ b/drivers/staging/lustre/lustre/lov/lov_request.c
@@ -140,14 +140,14 @@ void lov_set_add_req(struct lov_request *req, struct lov_request_set *set)
static int lov_check_set(struct lov_obd *lov, int idx)
{
- int rc = 0;
+ int rc;
+ struct lov_tgt_desc *tgt;
mutex_lock(&lov->lov_lock);
- if (lov->lov_tgts[idx] == NULL ||
- lov->lov_tgts[idx]->ltd_active ||
- (lov->lov_tgts[idx]->ltd_exp != NULL &&
- class_exp2cliimp(lov->lov_tgts[idx]->ltd_exp)->imp_connect_tried))
- rc = 1;
+ tgt = lov->lov_tgts[idx];
+ rc = !tgt || tgt->ltd_active ||
+ (tgt->ltd_exp &&
+ class_exp2cliimp(tgt->ltd_exp)->imp_connect_tried);
mutex_unlock(&lov->lov_lock);
return rc;
--
1.9.1
next prev parent reply other threads:[~2014-07-21 10:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-19 19:34 staging: lustre/lustre/lov: Cleanup style issues " Riccardo Lucchese
2014-07-19 19:34 ` [PATCH 1/3] staging: lustre/lustre/lov: Remove unneeded 'if' statement in lov_request.c/lov_check_set() Riccardo Lucchese
2014-07-19 19:59 ` Joe Perches
2014-07-20 11:03 ` Riccardo Lucchese
2014-07-20 4:52 ` Dan Carpenter
2014-07-20 11:08 ` Riccardo Lucchese
2014-07-20 11:37 ` Dan Carpenter
2014-07-20 12:27 ` Riccardo Lucchese
2014-07-20 13:22 ` staging: lustre: lov: Cleanup style issues in lov_request.c Riccardo Lucchese
2014-07-20 13:22 ` [PATCH v2 1/3] staging: lustre: lov: Cleanup lov_check_set() " Riccardo Lucchese
2014-07-20 15:30 ` Joe Perches
2014-07-20 16:01 ` Riccardo Lucchese
2014-07-21 10:15 ` staging: lustre: lov: Cleanup style issues " Riccardo Lucchese
2014-07-21 10:15 ` Riccardo Lucchese [this message]
2014-07-21 10:15 ` [PATCH v3 2/3] staging: lustre: lov: Add a blank line after declarations " Riccardo Lucchese
2014-07-21 10:19 ` [PATCH v3 3/3] staging: lustre: lov: Add a space before open braces '{' " Riccardo Lucchese
2014-07-20 13:22 ` [PATCH v2 2/3] staging: lustre: lov: Add a blank line after declarations " Riccardo Lucchese
2014-07-20 13:22 ` [PATCH v2 3/3] staging: lustre: lov: Add a space before open braces '{' " Riccardo Lucchese
2014-07-19 19:34 ` [PATCH 2/3] staging: lustre/lustre/lov: Add a blank line after declarations " Riccardo Lucchese
2014-07-19 19:41 ` [PATCH 3/3] staging: lustre/lustre/lov: Add a space before open braces '{' " Riccardo Lucchese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405937757-16504-2-git-send-email-riccardo.lucchese@gmail.com \
--to=riccardo.lucchese@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dmitry.eremin@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=john.hammond@intel.com \
--cc=josh@joshtriplett.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®