From: Riccardo Lucchese <riccardo.lucchese@gmail.com>
To: gregkh@linuxfoundation.org
Cc: dan.carpenter@oracle.com, oleg.drokin@intel.com,
josh@joshtriplett.org, dmitry.eremin@intel.com,
john.hammond@intel.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, julia.lawall@lip6.fr,
joe@perches.com, Riccardo Lucchese <riccardo.lucchese@gmail.com>
Subject: [PATCH v3 2/3] staging: lustre: lov: Add a blank line after declarations in lov_request.c
Date: Mon, 21 Jul 2014 12:15:56 +0200 [thread overview]
Message-ID: <1405937757-16504-3-git-send-email-riccardo.lucchese@gmail.com> (raw)
In-Reply-To: <1405937757-16504-1-git-send-email-riccardo.lucchese@gmail.com>
Fix the following checkpatch.pl issue in lov_request.c:
WARNING: Missing a blank line after declarations
Signed-off-by: Riccardo Lucchese <riccardo.lucchese@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
No changes in v3.
Changes in v2:
- Changed the subject line to follow the same convention used by
previous commits to the same file.
- Added Acked-by - Julia.
drivers/staging/lustre/lustre/lov/lov_request.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_request.c b/drivers/staging/lustre/lustre/lov/lov_request.c
index da424de..887b4b0 100644
--- a/drivers/staging/lustre/lustre/lov/lov_request.c
+++ b/drivers/staging/lustre/lustre/lov/lov_request.c
@@ -142,14 +142,14 @@ static int lov_check_set(struct lov_obd *lov, int idx)
{
int rc;
struct lov_tgt_desc *tgt;
- mutex_lock(&lov->lov_lock);
+ mutex_lock(&lov->lov_lock);
tgt = lov->lov_tgts[idx];
rc = !tgt || tgt->ltd_active ||
(tgt->ltd_exp &&
class_exp2cliimp(tgt->ltd_exp)->imp_connect_tried);
-
mutex_unlock(&lov->lov_lock);
+
return rc;
}
@@ -836,6 +836,7 @@ static int cb_getattr_update(void *cookie, int rc)
{
struct obd_info *oinfo = cookie;
struct lov_request *lovreq;
+
lovreq = container_of(oinfo, struct lov_request, rq_oi);
return lov_update_common_set(lovreq->rq_rqset, lovreq, rc);
}
@@ -1018,6 +1019,7 @@ static int cb_setattr_update(void *cookie, int rc)
{
struct obd_info *oinfo = cookie;
struct lov_request *lovreq;
+
lovreq = container_of(oinfo, struct lov_request, rq_oi);
return lov_update_setattr_set(lovreq->rq_rqset, lovreq, rc);
}
@@ -1141,6 +1143,7 @@ static int cb_update_punch(void *cookie, int rc)
{
struct obd_info *oinfo = cookie;
struct lov_request *lovreq;
+
lovreq = container_of(oinfo, struct lov_request, rq_oi);
return lov_update_punch_set(lovreq->rq_rqset, lovreq, rc);
}
--
1.9.1
next prev parent reply other threads:[~2014-07-21 10:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-19 19:34 staging: lustre/lustre/lov: Cleanup style issues " Riccardo Lucchese
2014-07-19 19:34 ` [PATCH 1/3] staging: lustre/lustre/lov: Remove unneeded 'if' statement in lov_request.c/lov_check_set() Riccardo Lucchese
2014-07-19 19:59 ` Joe Perches
2014-07-20 11:03 ` Riccardo Lucchese
2014-07-20 4:52 ` Dan Carpenter
2014-07-20 11:08 ` Riccardo Lucchese
2014-07-20 11:37 ` Dan Carpenter
2014-07-20 12:27 ` Riccardo Lucchese
2014-07-20 13:22 ` staging: lustre: lov: Cleanup style issues in lov_request.c Riccardo Lucchese
2014-07-20 13:22 ` [PATCH v2 1/3] staging: lustre: lov: Cleanup lov_check_set() " Riccardo Lucchese
2014-07-20 15:30 ` Joe Perches
2014-07-20 16:01 ` Riccardo Lucchese
2014-07-21 10:15 ` staging: lustre: lov: Cleanup style issues " Riccardo Lucchese
2014-07-21 10:15 ` [PATCH v3 1/3] staging: lustre: lov: Cleanup lov_check_set() " Riccardo Lucchese
2014-07-21 10:15 ` Riccardo Lucchese [this message]
2014-07-21 10:19 ` [PATCH v3 3/3] staging: lustre: lov: Add a space before open braces '{' " Riccardo Lucchese
2014-07-20 13:22 ` [PATCH v2 2/3] staging: lustre: lov: Add a blank line after declarations " Riccardo Lucchese
2014-07-20 13:22 ` [PATCH v2 3/3] staging: lustre: lov: Add a space before open braces '{' " Riccardo Lucchese
2014-07-19 19:34 ` [PATCH 2/3] staging: lustre/lustre/lov: Add a blank line after declarations " Riccardo Lucchese
2014-07-19 19:41 ` [PATCH 3/3] staging: lustre/lustre/lov: Add a space before open braces '{' " Riccardo Lucchese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405937757-16504-3-git-send-email-riccardo.lucchese@gmail.com \
--to=riccardo.lucchese@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=dmitry.eremin@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=john.hammond@intel.com \
--cc=josh@joshtriplett.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®