From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: sameo@linux.intel.com, Lee Jones <lee.jones@linaro.org>
Subject: [PATCH 15/19] mfd: tc6387xb: Remove unnecessary braces and correct style warnings
Date: Tue, 22 Jul 2014 12:11:21 +0100 [thread overview]
Message-ID: <1406027485-15657-16-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1406027485-15657-1-git-send-email-lee.jones@linaro.org>
This is part of an effort to clean-up the MFD subsystem.
WARNING: braces {} are not necessary for single statement blocks
+ if (!iomem) {
+ return -EINVAL;
+ }
WARNING: sizeof *tc6387xb should be sizeof(*tc6387xb)
+ tc6387xb = kzalloc(sizeof *tc6387xb, GFP_KERNEL);
WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
+ printk(KERN_INFO "Toshiba tc6387xb initialised\n");
total: 0 errors, 3 warnings, 242 lines checked
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/mfd/tc6387xb.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/mfd/tc6387xb.c b/drivers/mfd/tc6387xb.c
index 591a331..e71f880 100644
--- a/drivers/mfd/tc6387xb.c
+++ b/drivers/mfd/tc6387xb.c
@@ -147,11 +147,10 @@ static int tc6387xb_probe(struct platform_device *dev)
int irq, ret;
iomem = platform_get_resource(dev, IORESOURCE_MEM, 0);
- if (!iomem) {
+ if (!iomem)
return -EINVAL;
- }
- tc6387xb = kzalloc(sizeof *tc6387xb, GFP_KERNEL);
+ tc6387xb = kzalloc(sizeof(*tc6387xb), GFP_KERNEL);
if (!tc6387xb)
return -ENOMEM;
@@ -189,7 +188,7 @@ static int tc6387xb_probe(struct platform_device *dev)
if (pdata && pdata->enable)
pdata->enable(dev);
- printk(KERN_INFO "Toshiba tc6387xb initialised\n");
+ dev_info(&dev->dev, "Toshiba tc6387xb initialised\n");
ret = mfd_add_devices(&dev->dev, dev->id, tc6387xb_cells,
ARRAY_SIZE(tc6387xb_cells), iomem, irq, NULL);
--
1.8.3.2
next prev parent reply other threads:[~2014-07-22 11:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 11:11 [PATCH 00/19] mfd: Fix checkpatch errors Lee Jones
2014-07-22 11:11 ` [PATCH 01/19] mfd: max77686: Fix 'line over 80 chars' warning Lee Jones
2014-07-22 11:45 ` pramod gurav
2014-07-22 12:13 ` Lee Jones
2014-07-22 12:27 ` pramod gurav
2014-07-22 11:11 ` [PATCH 02/19] mfd: max8925-i2c: Fix 'blank line after declarations' warning Lee Jones
2014-07-22 11:50 ` pramod gurav
2014-07-22 12:15 ` Lee Jones
[not found] ` <CAMf-jSmyJ1r8eFe-kU2LwgYzNuqkNqNHvUVk088f4AUaULEugg@mail.gmail.com>
2014-07-22 14:03 ` Lee Jones
2014-07-22 11:11 ` [PATCH 03/19] mfd: tps80031: Fix 'missing break or fall-through comment' warning Lee Jones
2014-07-22 11:33 ` Arnd Bergmann
2014-07-22 12:08 ` Lee Jones
2014-07-22 11:11 ` [PATCH 04/19] mfd: mcp-core: Fix 'blank line after declarations' warning Lee Jones
2014-07-22 11:11 ` [PATCH 05/19] mfd: wm8350-irq: Fix 'line over 80 chars' warning Lee Jones
2014-07-22 11:11 ` [PATCH 06/19] mfd: dm355evm_msp: Fix checkpatch error: insert space after ',' Lee Jones
2014-07-22 11:11 ` [PATCH 07/19] mfd: sec-core: Fix 'missing blank line after declarations' warning Lee Jones
2014-07-22 11:11 ` [PATCH 08/19] mfd: twl6040: Fix 'insert space after ','', error Lee Jones
2014-07-22 11:11 ` [PATCH 09/19] mfd: ezx-pcap: Repair coding style errors picked up with checkpatch Lee Jones
2014-07-22 13:33 ` Joe Perches
2014-07-22 13:48 ` Lee Jones
2014-07-22 11:11 ` [PATCH 10/19] mfd: lp8788-irq: Fix 'missing blank line after declarations' warning Lee Jones
2014-07-22 11:11 ` [PATCH 11/19] mfd: twl4030-irq: Fix style warnings relating to pr_warn() and sizeof() Lee Jones
2014-07-22 11:11 ` [PATCH 12/19] mfd: max8925-core: Fix 'missing blank line after declarations' warning Lee Jones
2014-07-22 11:11 ` [PATCH 13/19] mfd: wm8350-i2c: Replace spaces with tabs Lee Jones
2014-07-22 11:11 ` [PATCH 14/19] mfd: twl6030-irq: Extinguish coding style warnings Lee Jones
2014-07-22 11:11 ` Lee Jones [this message]
2014-07-22 11:11 ` [PATCH 16/19] mfd: si476x-cmd: Remedy checkpatch style complains Lee Jones
2014-07-22 11:11 ` [PATCH 17/19] mfd: ipaq-micro: Fix coding style errors/warnings reported by checkpatch Lee Jones
2014-07-22 11:11 ` [PATCH 18/19] mfd: kempld-core: Correct a variety of checkpatch warnings Lee Jones
2014-07-22 11:11 ` [PATCH 19/19] mfd: wm8997-tables: Suppress 'line over 80 chars' warnings Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406027485-15657-16-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®