mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: sameo@linux.intel.com, Lee Jones <lee.jones@linaro.org>
Subject: [PATCH 17/19] mfd: ipaq-micro: Fix coding style errors/warnings reported by checkpatch
Date: Tue, 22 Jul 2014 12:11:23 +0100	[thread overview]
Message-ID: <1406027485-15657-18-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1406027485-15657-1-git-send-email-lee.jones@linaro.org>

This is part of an effort to clean-up the MFD subsystem.

ERROR: space required before the open parenthesis '('
+                       if(!micro->msg)

WARNING: unnecessary whitespace before a quoted newline
+                       dev_dbg(micro->dev, "key message ignored, no handle \n");

WARNING: unnecessary whitespace before a quoted newline
+                       dev_dbg(micro->dev, "touchscreen message ignored, no handle \n");

WARNING: space prohibited before semicolon
+               rx->id = (ch & 0xf0) >> 4 ;

total: 1 errors, 3 warnings, 482 lines checked

Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/ipaq-micro.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c
index 7e50fe0..8df3266 100644
--- a/drivers/mfd/ipaq-micro.c
+++ b/drivers/mfd/ipaq-micro.c
@@ -115,7 +115,7 @@ static void micro_rx_msg(struct ipaq_micro *micro, u8 id, int len, u8 *data)
 		} else {
 			dev_err(micro->dev,
 				"out of band RX message 0x%02x\n", id);
-			if(!micro->msg)
+			if (!micro->msg)
 				dev_info(micro->dev, "no message queued\n");
 			else
 				dev_info(micro->dev, "expected message %02x\n",
@@ -126,13 +126,13 @@ static void micro_rx_msg(struct ipaq_micro *micro, u8 id, int len, u8 *data)
 		if (micro->key)
 			micro->key(micro->key_data, len, data);
 		else
-			dev_dbg(micro->dev, "key message ignored, no handle \n");
+			dev_dbg(micro->dev, "key message ignored, no handle\n");
 		break;
 	case MSG_TOUCHSCREEN:
 		if (micro->ts)
 			micro->ts(micro->ts_data, len, data);
 		else
-			dev_dbg(micro->dev, "touchscreen message ignored, no handle \n");
+			dev_dbg(micro->dev, "touchscreen message ignored, no handle\n");
 		break;
 	default:
 		dev_err(micro->dev,
@@ -154,7 +154,7 @@ static void micro_process_char(struct ipaq_micro *micro, u8 ch)
 			rx->state = STATE_ID; /* Next byte is the id and len */
 		break;
 	case STATE_ID: /* Looking for id and len byte */
-		rx->id = (ch & 0xf0) >> 4 ;
+		rx->id = (ch & 0xf0) >> 4;
 		rx->len = (ch & 0x0f);
 		rx->index = 0;
 		rx->chksum = ch;
-- 
1.8.3.2


  parent reply	other threads:[~2014-07-22 11:12 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-22 11:11 [PATCH 00/19] mfd: Fix checkpatch errors Lee Jones
2014-07-22 11:11 ` [PATCH 01/19] mfd: max77686: Fix 'line over 80 chars' warning Lee Jones
2014-07-22 11:45   ` pramod gurav
2014-07-22 12:13     ` Lee Jones
2014-07-22 12:27       ` pramod gurav
2014-07-22 11:11 ` [PATCH 02/19] mfd: max8925-i2c: Fix 'blank line after declarations' warning Lee Jones
2014-07-22 11:50   ` pramod gurav
2014-07-22 12:15     ` Lee Jones
     [not found]       ` <CAMf-jSmyJ1r8eFe-kU2LwgYzNuqkNqNHvUVk088f4AUaULEugg@mail.gmail.com>
2014-07-22 14:03         ` Lee Jones
2014-07-22 11:11 ` [PATCH 03/19] mfd: tps80031: Fix 'missing break or fall-through comment' warning Lee Jones
2014-07-22 11:33   ` Arnd Bergmann
2014-07-22 12:08     ` Lee Jones
2014-07-22 11:11 ` [PATCH 04/19] mfd: mcp-core: Fix 'blank line after declarations' warning Lee Jones
2014-07-22 11:11 ` [PATCH 05/19] mfd: wm8350-irq: Fix 'line over 80 chars' warning Lee Jones
2014-07-22 11:11 ` [PATCH 06/19] mfd: dm355evm_msp: Fix checkpatch error: insert space after ',' Lee Jones
2014-07-22 11:11 ` [PATCH 07/19] mfd: sec-core: Fix 'missing blank line after declarations' warning Lee Jones
2014-07-22 11:11 ` [PATCH 08/19] mfd: twl6040: Fix 'insert space after ','', error Lee Jones
2014-07-22 11:11 ` [PATCH 09/19] mfd: ezx-pcap: Repair coding style errors picked up with checkpatch Lee Jones
2014-07-22 13:33   ` Joe Perches
2014-07-22 13:48     ` Lee Jones
2014-07-22 11:11 ` [PATCH 10/19] mfd: lp8788-irq: Fix 'missing blank line after declarations' warning Lee Jones
2014-07-22 11:11 ` [PATCH 11/19] mfd: twl4030-irq: Fix style warnings relating to pr_warn() and sizeof() Lee Jones
2014-07-22 11:11 ` [PATCH 12/19] mfd: max8925-core: Fix 'missing blank line after declarations' warning Lee Jones
2014-07-22 11:11 ` [PATCH 13/19] mfd: wm8350-i2c: Replace spaces with tabs Lee Jones
2014-07-22 11:11 ` [PATCH 14/19] mfd: twl6030-irq: Extinguish coding style warnings Lee Jones
2014-07-22 11:11 ` [PATCH 15/19] mfd: tc6387xb: Remove unnecessary braces and correct " Lee Jones
2014-07-22 11:11 ` [PATCH 16/19] mfd: si476x-cmd: Remedy checkpatch style complains Lee Jones
2014-07-22 11:11 ` Lee Jones [this message]
2014-07-22 11:11 ` [PATCH 18/19] mfd: kempld-core: Correct a variety of checkpatch warnings Lee Jones
2014-07-22 11:11 ` [PATCH 19/19] mfd: wm8997-tables: Suppress 'line over 80 chars' warnings Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406027485-15657-18-git-send-email-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®