mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fabian Frederick <fabf@skynet.be>
To: linux-kernel@vger.kernel.org
Cc: joe@perches.com, gregkh@linuxfoundation.org,
	Fabian Frederick <fabf@skynet.be>,
	linux-usb@vger.kernel.org
Subject: [PATCH 01/10 linux-next] USB: iowarrior: remove unnecessary break after goto
Date: Thu, 24 Jul 2014 10:18:49 +0200	[thread overview]
Message-ID: <1406189939-6433-2-git-send-email-fabf@skynet.be> (raw)
In-Reply-To: <1406189939-6433-1-git-send-email-fabf@skynet.be>

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 drivers/usb/misc/iowarrior.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c
index c6bfd13..17ce9a4 100644
--- a/drivers/usb/misc/iowarrior.c
+++ b/drivers/usb/misc/iowarrior.c
@@ -381,7 +381,6 @@ static ssize_t iowarrior_write(struct file *file,
 		retval = usb_set_report(dev->interface, 2, 0, buf, count);
 		kfree(buf);
 		goto exit;
-		break;
 	case USB_DEVICE_ID_CODEMERCS_IOW56:
 		/* The IOW56 uses asynchronous IO and more urbs */
 		if (atomic_read(&dev->write_busy) == MAX_WRITES_IN_FLIGHT) {
@@ -447,14 +446,12 @@ static ssize_t iowarrior_write(struct file *file,
 		retval = count;
 		usb_free_urb(int_out_urb);
 		goto exit;
-		break;
 	default:
 		/* what do we have here ? An unsupported Product-ID ? */
 		dev_err(&dev->interface->dev, "%s - not supported for product=0x%x\n",
 			__func__, dev->product_id);
 		retval = -EFAULT;
 		goto exit;
-		break;
 	}
 error:
 	usb_free_coherent(dev->udev, dev->report_size, buf,
-- 
1.8.4.5


  reply	other threads:[~2014-07-24  8:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-24  8:18 [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return Fabian Frederick
2014-07-24  8:18 ` Fabian Frederick [this message]
2014-07-24  8:18 ` [PATCH 02/10 linux-next] USB: usblcd: remove unnecessary break after return Fabian Frederick
2014-07-24  8:18 ` [PATCH 03/10 linux-next] usb: dcw3: " Fabian Frederick
2014-07-24  8:18 ` [PATCH 04/10 linux-next] usb: gadget: " Fabian Frederick
2014-07-24  8:18 ` [PATCH 05/10 linux-next] usb: gadget: remove unnecessary break after goto Fabian Frederick
2014-07-24  8:18 ` [PATCH 06/10 linux-next] xhci: remove unnecessary break after return Fabian Frederick
2014-07-24 11:43   ` Mathias Nyman
2014-07-24  8:18 ` [PATCH 07/10 linux-next] usb: storage: " Fabian Frederick
2014-07-24  8:18 ` [PATCH 08/10 linux-next] USB: serial: " Fabian Frederick
2014-07-24  8:18 ` [PATCH 09/10 linux-next] USB: ftdi_sio: " Fabian Frederick
2014-07-24  8:24 ` [PATCH 10/10 linux-next] USB: microtek: remove unnecessary break after goto Fabian Frederick
2014-07-24 11:37 ` [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return Oliver Neukum
2014-07-24 15:46   ` Fabian Frederick
2014-07-24 15:52     ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406189939-6433-2-git-send-email-fabf@skynet.be \
    --to=fabf@skynet.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®