mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fabian Frederick <fabf@skynet.be>
To: linux-kernel@vger.kernel.org
Cc: joe@perches.com, gregkh@linuxfoundation.org,
	Fabian Frederick <fabf@skynet.be>, Felipe Balbi <balbi@ti.com>,
	linux-usb@vger.kernel.org
Subject: [PATCH 05/10 linux-next] usb: gadget: remove unnecessary break after goto
Date: Thu, 24 Jul 2014 10:18:53 +0200	[thread overview]
Message-ID: <1406189939-6433-6-git-send-email-fabf@skynet.be> (raw)
In-Reply-To: <1406189939-6433-1-git-send-email-fabf@skynet.be>

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 drivers/usb/gadget/function/f_hid.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/usb/gadget/function/f_hid.c b/drivers/usb/gadget/function/f_hid.c
index a95290a..21c4b9c 100644
--- a/drivers/usb/gadget/function/f_hid.c
+++ b/drivers/usb/gadget/function/f_hid.c
@@ -386,25 +386,21 @@ static int hidg_setup(struct usb_function *f,
 		memset(req->buf, 0x0, length);
 
 		goto respond;
-		break;
 
 	case ((USB_DIR_IN | USB_TYPE_CLASS | USB_RECIP_INTERFACE) << 8
 		  | HID_REQ_GET_PROTOCOL):
 		VDBG(cdev, "get_protocol\n");
 		goto stall;
-		break;
 
 	case ((USB_DIR_OUT | USB_TYPE_CLASS | USB_RECIP_INTERFACE) << 8
 		  | HID_REQ_SET_REPORT):
 		VDBG(cdev, "set_report | wLenght=%d\n", ctrl->wLength);
 		goto stall;
-		break;
 
 	case ((USB_DIR_OUT | USB_TYPE_CLASS | USB_RECIP_INTERFACE) << 8
 		  | HID_REQ_SET_PROTOCOL):
 		VDBG(cdev, "set_protocol\n");
 		goto stall;
-		break;
 
 	case ((USB_DIR_IN | USB_TYPE_STANDARD | USB_RECIP_INTERFACE) << 8
 		  | USB_REQ_GET_DESCRIPTOR):
@@ -415,20 +411,17 @@ static int hidg_setup(struct usb_function *f,
 						   hidg_desc.bLength);
 			memcpy(req->buf, &hidg_desc, length);
 			goto respond;
-			break;
 		case HID_DT_REPORT:
 			VDBG(cdev, "USB_REQ_GET_DESCRIPTOR: REPORT\n");
 			length = min_t(unsigned short, length,
 						   hidg->report_desc_length);
 			memcpy(req->buf, hidg->report_desc, length);
 			goto respond;
-			break;
 
 		default:
 			VDBG(cdev, "Unknown descriptor request 0x%x\n",
 				 value >> 8);
 			goto stall;
-			break;
 		}
 		break;
 
@@ -436,7 +429,6 @@ static int hidg_setup(struct usb_function *f,
 		VDBG(cdev, "Unknown request 0x%x\n",
 			 ctrl->bRequest);
 		goto stall;
-		break;
 	}
 
 stall:
-- 
1.8.4.5


  parent reply	other threads:[~2014-07-24  8:18 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-24  8:18 [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return Fabian Frederick
2014-07-24  8:18 ` [PATCH 01/10 linux-next] USB: iowarrior: remove unnecessary break after goto Fabian Frederick
2014-07-24  8:18 ` [PATCH 02/10 linux-next] USB: usblcd: remove unnecessary break after return Fabian Frederick
2014-07-24  8:18 ` [PATCH 03/10 linux-next] usb: dcw3: " Fabian Frederick
2014-07-24  8:18 ` [PATCH 04/10 linux-next] usb: gadget: " Fabian Frederick
2014-07-24  8:18 ` Fabian Frederick [this message]
2014-07-24  8:18 ` [PATCH 06/10 linux-next] xhci: " Fabian Frederick
2014-07-24 11:43   ` Mathias Nyman
2014-07-24  8:18 ` [PATCH 07/10 linux-next] usb: storage: " Fabian Frederick
2014-07-24  8:18 ` [PATCH 08/10 linux-next] USB: serial: " Fabian Frederick
2014-07-24  8:18 ` [PATCH 09/10 linux-next] USB: ftdi_sio: " Fabian Frederick
2014-07-24  8:24 ` [PATCH 10/10 linux-next] USB: microtek: remove unnecessary break after goto Fabian Frederick
2014-07-24 11:37 ` [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return Oliver Neukum
2014-07-24 15:46   ` Fabian Frederick
2014-07-24 15:52     ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406189939-6433-6-git-send-email-fabf@skynet.be \
    --to=fabf@skynet.be \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®