From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, laijs@cn.fujitsu.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com,
bobby.prani@gmail.com,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: [PATCH v3 tip/core/rcu 5/9] rcutorture: Add torture tests for RCU-tasks
Date: Thu, 31 Jul 2014 14:55:05 -0700 [thread overview]
Message-ID: <1406843709-23396-5-git-send-email-paulmck@linux.vnet.ibm.com> (raw)
In-Reply-To: <1406843709-23396-1-git-send-email-paulmck@linux.vnet.ibm.com>
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
This commit adds torture tests for RCU-tasks. It also fixes a bug that
would segfault for an RCU flavor lacking a callback-barrier function.
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
include/linux/rcupdate.h | 1 +
kernel/rcu/rcutorture.c | 40 +++++++++++++++++++++++++++++++++++++++-
2 files changed, 40 insertions(+), 1 deletion(-)
diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h
index 1f073af940a5..f9d314bbc7b6 100644
--- a/include/linux/rcupdate.h
+++ b/include/linux/rcupdate.h
@@ -55,6 +55,7 @@ enum rcutorture_type {
RCU_FLAVOR,
RCU_BH_FLAVOR,
RCU_SCHED_FLAVOR,
+ RCU_TASKS_FLAVOR,
SRCU_FLAVOR,
INVALID_RCU_FLAVOR
};
diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
index febe07062ac5..6d12ab6675bc 100644
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -602,6 +602,42 @@ static struct rcu_torture_ops sched_ops = {
};
/*
+ * Definitions for RCU-tasks torture testing.
+ */
+
+static int tasks_torture_read_lock(void)
+{
+ return 0;
+}
+
+static void tasks_torture_read_unlock(int idx)
+{
+}
+
+static void rcu_tasks_torture_deferred_free(struct rcu_torture *p)
+{
+ call_rcu_tasks(&p->rtort_rcu, rcu_torture_cb);
+}
+
+static struct rcu_torture_ops tasks_ops = {
+ .ttype = RCU_TASKS_FLAVOR,
+ .init = rcu_sync_torture_init,
+ .readlock = tasks_torture_read_lock,
+ .read_delay = rcu_read_delay, /* just reuse rcu's version. */
+ .readunlock = tasks_torture_read_unlock,
+ .completed = rcu_no_completed,
+ .deferred_free = rcu_tasks_torture_deferred_free,
+ .sync = synchronize_rcu_tasks,
+ .exp_sync = synchronize_rcu_tasks,
+ .call = call_rcu_tasks,
+ .cb_barrier = rcu_barrier_tasks,
+ .fqs = NULL,
+ .stats = NULL,
+ .irq_capable = 1,
+ .name = "tasks"
+};
+
+/*
* RCU torture priority-boost testing. Runs one real-time thread per
* CPU for moderate bursts, repeatedly registering RCU callbacks and
* spinning waiting for them to be invoked. If a given callback takes
@@ -1295,7 +1331,8 @@ static int rcu_torture_barrier_cbs(void *arg)
if (atomic_dec_and_test(&barrier_cbs_count))
wake_up(&barrier_wq);
} while (!torture_must_stop());
- cur_ops->cb_barrier();
+ if (cur_ops->cb_barrier != NULL)
+ cur_ops->cb_barrier();
destroy_rcu_head_on_stack(&rcu);
torture_kthread_stopping("rcu_torture_barrier_cbs");
return 0;
@@ -1534,6 +1571,7 @@ rcu_torture_init(void)
int firsterr = 0;
static struct rcu_torture_ops *torture_ops[] = {
&rcu_ops, &rcu_bh_ops, &rcu_busted_ops, &srcu_ops, &sched_ops,
+ &tasks_ops,
};
if (!torture_init_begin(torture_type, verbose, &rcutorture_runnable))
--
1.8.1.5
next prev parent reply other threads:[~2014-07-31 21:55 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 21:54 [PATCH v3 tip/core/rcu 0/9 Paul E. McKenney
2014-07-31 21:55 ` [PATCH v3 tip/core/rcu 1/9] rcu: Add call_rcu_tasks() Paul E. McKenney
2014-07-31 21:55 ` [PATCH v3 tip/core/rcu 2/9] rcu: Provide cond_resched_rcu_qs() to force quiescent states in long loops Paul E. McKenney
2014-07-31 21:55 ` [PATCH v3 tip/core/rcu 3/9] rcu: Add synchronous grace-period waiting for RCU-tasks Paul E. McKenney
2014-08-01 15:09 ` Oleg Nesterov
2014-08-01 18:32 ` Paul E. McKenney
2014-08-01 19:44 ` Paul E. McKenney
2014-08-02 14:47 ` Oleg Nesterov
2014-08-02 22:58 ` Paul E. McKenney
2014-08-06 0:57 ` Steven Rostedt
2014-08-06 1:21 ` Paul E. McKenney
2014-08-06 8:47 ` Peter Zijlstra
2014-08-06 12:09 ` Paul E. McKenney
2014-08-06 16:30 ` Peter Zijlstra
2014-08-06 22:45 ` Paul E. McKenney
2014-08-07 8:45 ` Peter Zijlstra
2014-08-07 15:00 ` Paul E. McKenney
2014-08-07 15:26 ` Peter Zijlstra
2014-08-07 17:27 ` Peter Zijlstra
2014-08-07 18:46 ` Peter Zijlstra
2014-08-07 19:49 ` Steven Rostedt
2014-08-07 19:53 ` Steven Rostedt
2014-08-07 20:08 ` Peter Zijlstra
2014-08-07 21:18 ` Steven Rostedt
2014-08-08 6:40 ` Peter Zijlstra
2014-08-08 14:12 ` Steven Rostedt
2014-08-08 14:28 ` Paul E. McKenney
2014-08-09 10:56 ` Masami Hiramatsu
2014-08-08 14:34 ` Peter Zijlstra
2014-08-08 14:58 ` Steven Rostedt
2014-08-08 15:16 ` Peter Zijlstra
2014-08-08 15:39 ` Steven Rostedt
2014-08-08 16:01 ` Peter Zijlstra
2014-08-08 16:10 ` Steven Rostedt
2014-08-08 16:17 ` Peter Zijlstra
2014-08-08 16:40 ` Steven Rostedt
2014-08-08 16:52 ` Peter Zijlstra
2014-08-08 16:27 ` Peter Zijlstra
2014-08-08 16:39 ` Paul E. McKenney
2014-08-08 16:49 ` Steven Rostedt
2014-08-08 16:51 ` Peter Zijlstra
2014-08-08 17:09 ` Paul E. McKenney
2014-08-08 16:43 ` Steven Rostedt
2014-08-08 16:50 ` Peter Zijlstra
2014-08-08 17:27 ` Steven Rostedt
2014-08-09 10:36 ` Masami Hiramatsu
2014-08-07 20:06 ` Peter Zijlstra
2014-07-31 21:55 ` [PATCH v3 tip/core/rcu 4/9] rcu: Export RCU-tasks APIs to GPL modules Paul E. McKenney
2014-07-31 21:55 ` Paul E. McKenney [this message]
2014-07-31 21:55 ` [PATCH v3 tip/core/rcu 6/9] rcutorture: Add RCU-tasks test cases Paul E. McKenney
2014-07-31 21:55 ` [PATCH v3 tip/core/rcu 7/9] rcu: Add stall-warning checks for RCU-tasks Paul E. McKenney
2014-07-31 21:55 ` [PATCH v3 tip/core/rcu 8/9] rcu: Improve RCU-tasks energy efficiency Paul E. McKenney
2014-07-31 21:55 ` [PATCH v3 tip/core/rcu 9/9] documentation: Add verbiage on RCU-tasks stall warning messages Paul E. McKenney
2014-07-31 23:57 ` [PATCH v3 tip/core/rcu 1/9] rcu: Add call_rcu_tasks() Frederic Weisbecker
2014-08-01 2:04 ` Paul E. McKenney
2014-08-01 15:06 ` Frederic Weisbecker
2014-08-01 1:15 ` Lai Jiangshan
2014-08-01 1:59 ` Paul E. McKenney
2014-08-01 1:31 ` Lai Jiangshan
2014-08-01 2:11 ` Paul E. McKenney
2014-08-01 14:11 ` Oleg Nesterov
2014-08-01 18:28 ` Paul E. McKenney
2014-08-01 18:40 ` Oleg Nesterov
2014-08-02 23:00 ` Paul E. McKenney
2014-08-03 12:57 ` Oleg Nesterov
2014-08-03 22:03 ` Paul E. McKenney
2014-08-04 13:29 ` Oleg Nesterov
2014-08-04 13:48 ` Paul E. McKenney
2014-08-01 18:57 ` Oleg Nesterov
2014-08-02 22:50 ` Paul E. McKenney
2014-08-02 14:56 ` Oleg Nesterov
2014-08-02 22:57 ` Paul E. McKenney
2014-08-03 13:33 ` Oleg Nesterov
2014-08-03 22:05 ` Paul E. McKenney
2014-08-04 0:37 ` Lai Jiangshan
2014-08-04 1:09 ` Paul E. McKenney
2014-08-04 13:25 ` Oleg Nesterov
2014-08-04 13:51 ` Paul E. McKenney
2014-08-04 13:52 ` Paul E. McKenney
2014-08-04 13:32 ` Oleg Nesterov
2014-08-04 19:28 ` Paul E. McKenney
2014-08-04 19:32 ` Oleg Nesterov
2014-08-04 1:28 ` Lai Jiangshan
2014-08-04 7:46 ` Peter Zijlstra
2014-08-04 8:18 ` Lai Jiangshan
2014-08-04 11:50 ` Paul E. McKenney
2014-08-04 12:25 ` Peter Zijlstra
2014-08-04 12:37 ` Paul E. McKenney
2014-08-04 14:56 ` Peter Zijlstra
2014-08-05 0:47 ` Lai Jiangshan
2014-08-05 21:55 ` Paul E. McKenney
2014-08-06 0:27 ` Lai Jiangshan
2014-08-06 0:48 ` Paul E. McKenney
2014-08-06 0:33 ` Lai Jiangshan
2014-08-06 0:51 ` Paul E. McKenney
2014-08-06 22:48 ` Paul E. McKenney
2014-08-07 8:49 ` Peter Zijlstra
2014-08-07 15:43 ` Paul E. McKenney
2014-08-07 16:32 ` Peter Zijlstra
2014-08-07 17:48 ` Paul E. McKenney
2014-08-08 19:13 ` Peter Zijlstra
2014-08-08 20:58 ` Paul E. McKenney
2014-08-09 6:15 ` Peter Zijlstra
2014-08-09 12:44 ` Steven Rostedt
2014-08-09 16:05 ` Paul E. McKenney
2014-08-09 16:01 ` Paul E. McKenney
2014-08-09 18:19 ` Peter Zijlstra
2014-08-09 18:24 ` Peter Zijlstra
2014-08-10 1:29 ` Paul E. McKenney
2014-08-10 8:14 ` Peter Zijlstra
2014-08-11 3:30 ` Paul E. McKenney
2014-08-11 11:57 ` Peter Zijlstra
2014-08-11 16:15 ` Paul E. McKenney
2014-08-10 1:26 ` Paul E. McKenney
2014-08-10 8:12 ` Peter Zijlstra
2014-08-10 16:46 ` Peter Zijlstra
2014-08-11 3:28 ` Paul E. McKenney
2014-08-11 3:23 ` Paul E. McKenney
2014-08-09 18:33 ` Peter Zijlstra
2014-08-10 1:38 ` Paul E. McKenney
2014-08-10 15:00 ` Peter Zijlstra
2014-08-11 3:37 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406843709-23396-5-git-send-email-paulmck@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhart@linux.intel.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®