From: Joe Perches <joe@perches.com>
To: Dotan Barak <dotanb@mellanox.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch.pl report about "Missing blank line after declarations" in a structure definition
Date: Mon, 04 Aug 2014 06:35:42 -0700 [thread overview]
Message-ID: <1407159342.16152.63.camel@joe-AO725> (raw)
In-Reply-To: <3219ba81002f41d99c8651755dc2a920@DB3PR05MB380.eurprd05.prod.outlook.com>
On Mon, 2014-08-04 at 11:20 +0000, Dotan Barak wrote:
> Hi Joe.
>
> Thanks for fixing the issue that I reported about.
>
> It seems that even after your fix, there is still a false warning of "Missing blank line after declarations".
>
> I executed checkpatch.pl on a header file that exists in the Linux tree:
> # ./checkpatch.pl --file --no-tree ../include/linux/mlx5/cq.h
>
> And got the following warning:
>
> WARNING: Missing a blank line after declarations
> #49: FILE: ../include/linux/mlx5/cq.h:49:
> + int irqn;
> + void (*comp) (struct mlx5_core_cq *);
[]
> As you can see, this is a structure definition and IMHO the warning above is false.
The version in Linus' tree has a defect where
this test doesn't recognize function pointer
declarations.
This is fixed in -next since June, but it takes
awhile to get into Linus' tree.
https://lkml.org/lkml/2014/6/6/426
next prev parent reply other threads:[~2014-08-04 13:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 11:20 Dotan Barak
2014-08-04 13:35 ` Joe Perches [this message]
2014-08-04 14:14 ` Dotan Barak
2014-08-04 14:27 ` Joe Perches
2014-08-04 14:50 ` Dotan Barak
2014-08-04 15:11 ` Joe Perches
2014-08-04 15:19 ` Dotan Barak
2014-08-04 15:26 ` Joe Perches
2014-08-04 15:31 ` Dotan Barak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407159342.16152.63.camel@joe-AO725 \
--to=joe@perches.com \
--cc=dotanb@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®