From: Joe Perches <joe@perches.com>
To: Dotan Barak <dotanb@mellanox.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch.pl report about "Missing blank line after declarations" in a structure definition
Date: Mon, 04 Aug 2014 08:11:15 -0700 [thread overview]
Message-ID: <1407165075.16152.70.camel@joe-AO725> (raw)
In-Reply-To: <f95137f9228a4f08ba391f9640237d28@DB3PR05MB380.eurprd05.prod.outlook.com>
On Mon, 2014-08-04 at 14:50 +0000, Dotan Barak wrote:
> I think that allowing a prefix is reasonable (to allow modules to add more flexibility).
> I tried the suggested change and it still didn't work for me.
>
> The following change worked for me:
> (?:$Storage\s+)?[A-Z0-9_]*(?:DECLARE|DEFINE)_[A-Z_]*\s*\(|
>
> But, maybe it is better to be even more general and allow:
> (?:$Storage\s+)?[A-Z0-9_]*(?:DECLARE|DEFINE)_[ A-Z0-9_]*\s*\(|
Maybe:
(?:$Storage\s+)(?:[A-Z_][A-Z0-9]+_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,2}
next prev parent reply other threads:[~2014-08-04 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 11:20 Dotan Barak
2014-08-04 13:35 ` Joe Perches
2014-08-04 14:14 ` Dotan Barak
2014-08-04 14:27 ` Joe Perches
2014-08-04 14:50 ` Dotan Barak
2014-08-04 15:11 ` Joe Perches [this message]
2014-08-04 15:19 ` Dotan Barak
2014-08-04 15:26 ` Joe Perches
2014-08-04 15:31 ` Dotan Barak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407165075.16152.70.camel@joe-AO725 \
--to=joe@perches.com \
--cc=dotanb@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®